Skip to content

test: Negative case for fs Dir class initialisation without handler - #30313

Closed
Di9 wants to merge 1 commit into
nodejs:masterfrom
Di9:test-fs-dir-add
Closed

test: Negative case for fs Dir class initialisation without handler#30313
Di9 wants to merge 1 commit into
nodejs:masterfrom
Di9:test-fs-dir-add

Conversation

@Di9

@Di9Di9 commented Nov 6, 2019•
edited
Loading

Copy link
Copy Markdown

Covering the case when init Dir class without passing handler to constructor.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2019
@ChALkeRChALkeR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2019
trivikr
trivikr approved these changes Nov 6, 2019
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch which this PR covers can be viewed here https://coverage.nodejs.org/coverage-b6201abacf36cc49/lib/internal/fs/dir.js.html#L39

@Di9
Di9force-pushed the test-fs-dir-add branch 2 times, most recently from 67d5ee4 to f08b7fdCompareNovember 7, 2019 07:40
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26434/

Dmitriy Kikinskiy
test: dir class initialisation w/o handler
acdbc6c
Covering the case when init Dir class without passing
handle paramd to constructor.
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26583/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27033/

@gireeshpunathil

gireeshpunathil commented Nov 26, 2019

Copy link
Copy Markdown
Member

the failure in linux-containerized run node-api/test_make_callback/test-async-hooks-gcable is known as in #30648

the windows failure parallel/test-inspector-wait-for-connection is known as in #30619

the windows failure sequential/test-inspector-contexts is known as in #30519

gireeshpunathil pushed a commit that referenced this pull request Nov 26, 2019
Dmitriy Kikinskiy@gireeshpunathil
test: dir class initialisation w/o handler
8c41b19
Covering the case when init Dir class without passing
handle paramd to constructor.
PR-URL: #30313
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil

gireeshpunathil commented Nov 26, 2019

Copy link
Copy Markdown
Member

landed in 8c41b19.

thanks for the contribution!

addaleax pushed a commit that referenced this pull request Nov 30, 2019
Dmitriy Kikinskiy@addaleax
test: dir class initialisation w/o handler
d4b6170
Covering the case when init Dir class without passing
handle paramd to constructor.
PR-URL: #30313
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
Dmitriy Kikinskiy@targos
test: dir class initialisation w/o handler
c5e3816
Covering the case when init Dir class without passing
handle paramd to constructor.
PR-URL: #30313
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
Dmitriy Kikinskiy@MylesBorins
test: dir class initialisation w/o handler
12ef7d9
Covering the case when init Dir class without passing
handle paramd to constructor.
PR-URL: #30313
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Di9@nodejs-github-bot@gireeshpunathil@jasnell@lpinca@cjihrig@devnexen@BridgeAR@trivikr@ChALkeR