Skip to content

test: mark test-http-dump-req-when-res-ends as flaky on windows - #30316

Closed
AshCripps wants to merge 1 commit into
nodejs:masterfrom
AshCripps:http-dump-flake
Closed

test: mark test-http-dump-req-when-res-ends as flaky on windows#30316
AshCripps wants to merge 1 commit into
nodejs:masterfrom
AshCripps:http-dump-flake

Conversation

@AshCripps

Copy link
Copy Markdown
Member

Refs. #30011

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@sam-githubsam-github added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2019
@sam-github

Copy link
Copy Markdown
Contributor

Can I fast-track this to maximize greenness of CI?

@danbev

Copy link
Copy Markdown
Contributor

Landed in 8ac771b.

@danbevdanbev closed this Nov 11, 2019
danbev pushed a commit that referenced this pull request Nov 11, 2019
PR-URL: #30316
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
PR-URL: #30316
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeARBridgeAR mentioned this pull request Nov 19, 2019
targos pushed a commit that referenced this pull request Dec 1, 2019
PR-URL: #30316
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30316
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@AshCripps@nodejs-github-bot@sam-github@danbev@targos@cjihrig@BethGriggs@trivikr