Uh oh!
There was an error while loading. Please reload this page.
process: add coverage tests for sourceMapFromDataUrl method - #30319
Closed
Nolikzero wants to merge 2 commits into
Closed
process: add coverage tests for sourceMapFromDataUrl method#30319Nolikzero wants to merge 2 commits into
Nolikzero wants to merge 2 commits into
Conversation
addaleax
approved these changes
Nov 6, 2019
bcoe
approved these changes
Nov 6, 2019
bcoe
left a comment
Contributor
There was a problem hiding this comment.
these look like good tests to me 👍 did you confirm that they increase coverage?
Contributor
There was a problem hiding this comment.
could we add a comment above both of these blocks that describes the purpose of the test, e.g.,
"base64 encoding error does not crash application".
Member
There was a problem hiding this comment.
I took the liberty of adding two comments. LGTY?
BridgeAR
approved these changes
Nov 6, 2019
trivikr
approved these changes
Nov 8, 2019
nodejs-github-bot
commented
Nov 8, 2019
Collaborator
shisama
approved these changes
Nov 9, 2019
Trott
commented
Nov 9, 2019
Member
@Nolikzero FWIW, GitHub can't link your account to your contributions. See https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork to fix. (Basically, you'll need to add the email in your commit to https://github.com/settings/emails.) |
Trott pushed a commit
that referenced
this pull request
Nov 9, 2019
PR-URL: #30319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Trott
commented
Nov 9, 2019
Member
Landed in eb77321 Thanks for the contribution! 🎉 |
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes