Uh oh!
There was an error while loading. Please reload this page.
lib: change var into let - #30320
Closed
g-prokofyeva wants to merge 1 commit into
Closed
Conversation
Changed a variable declaration.
cjihrig
approved these changes
Nov 6, 2019
trivikr
approved these changes
Nov 6, 2019
addaleax
approved these changes
Nov 6, 2019
BridgeAR
approved these changes
Nov 6, 2019
ChALkeR
approved these changes
Nov 6, 2019
gengjiawen
approved these changes
Nov 7, 2019
gireeshpunathil
approved these changes
Nov 7, 2019
nodejs-github-bot
commented
Nov 7, 2019
Collaborator
gengjiawen
commented
Nov 7, 2019
Member
Nit: it's more clear if you can add filename in commit message. |
nodejs-github-bot
commented
Nov 8, 2019
Collaborator
Trott pushed a commit
that referenced
this pull request
Nov 8, 2019
Changed a variable declaration. PR-URL: #30320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Trott
commented
Nov 8, 2019
Member
Landed in 9a4b16f. I added the filename to the commit message. |
Trott
commented
Nov 8, 2019
Member
Thanks for the contribution! 🎉 |
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2019
Changed a variable declaration. PR-URL: #30320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
targos pushed a commit
that referenced
this pull request
Dec 1, 2019
Changed a variable declaration. PR-URL: #30320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
Changed a variable declaration. PR-URL: #30320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed a variable declaration.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes