Uh oh!
There was an error while loading. Please reload this page.
doc,meta: remove wait period for npm pull requests - #30329
Merged
Conversation
Trott
commented
Nov 8, 2019
MemberAuthor
richardlau
approved these changes
Nov 8, 2019
sam-github
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
@Trott - what would be an advantage of doing this? IMO a one week grace period is justified as a resiliency and quality measure.
MemberAuthor
There was a problem hiding this comment.
@gireeshpunathil I think it makes sense to withhold it from releases, but I'm less certain that there's much advantage to delaying it landing on master. There was relevant discussion about this in #29922. In that discussion, there seem to be a lot of people (especially if you include emoji reactions) in favor of getting rid of the delay and treating npm PRs like other PRs. But I'm totally OK if someone thinks this goes too far and blocks this change. Ultimately, I'm comfortable with changing it because we can always change the rule back.
gengjiawen
approved these changes
Nov 8, 2019
targos
approved these changes
Nov 8, 2019
Trott
commented
Nov 8, 2019
MemberAuthor
Going to @-mention @nodejs/tsc here as it seems like the right thing to do for a process change like this. |
trivikr
approved these changes
Nov 8, 2019
addaleax
approved these changes
Nov 8, 2019
BethGriggs
approved these changes
Nov 8, 2019
lpinca
approved these changes
Nov 8, 2019
Treat npm pull requests like all other pull requests. Remove special extended wait period for landing. PR-URL: nodejs#30329 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trottforce-pushed
the
remove-npm-wait-time
branch
from
November 10, 2019 04:12
026d819 to
5f9794eCompareTrott
commented
Nov 10, 2019
MemberAuthor
Landed in 5f9794e |
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2019
Treat npm pull requests like all other pull requests. Remove special extended wait period for landing. PR-URL: #30329 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Dec 1, 2019
Treat npm pull requests like all other pull requests. Remove special extended wait period for landing. PR-URL: #30329 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
Treat npm pull requests like all other pull requests. Remove special extended wait period for landing. PR-URL: #30329 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat npm pull requests like all other pull requests. Remove special
extended wait period for landing.
@nodejs/npm
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes