Skip to content

test: fix test-benchmark-cluster - #30342

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:fix-cluster-test
Nov 9, 2019
Merged

test: fix test-benchmark-cluster#30342
Trott merged 0 commit into
nodejs:masterfrom
Trott:fix-cluster-test

Conversation

@Trott

@TrottTrott commented Nov 9, 2019

Copy link
Copy Markdown
Member

test-benchmark-cluster needs to account for an option added in 973f324.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 9, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 9, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26495/

@Trott

Trott commented Nov 9, 2019

Copy link
Copy Markdown
MemberAuthor

This fixes the nightly node-daily-master CI job, so I'd like to fast-track it. 👍 if you're a Collaborator and you approve.

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 9, 2019
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 9, 2019
@Trott

Trott commented Nov 9, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in acd35d9

@TrottTrott closed this Nov 9, 2019
@TrottTrott reopened this Nov 9, 2019
@Trott
Trott merged commit acd35d9 into nodejs:masterNov 9, 2019
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@Trott@MylesBorins
test: fix test-benchmark-cluster
308f5e4
test-benchmark-cluster needs to account for an option added in 973f324.
PR-URL: #30342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeARBridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@Trott@targos
test: fix test-benchmark-cluster
4acd3c3
test-benchmark-cluster needs to account for an option added in 973f324.
PR-URL: #30342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Trott@MylesBorins
test: fix test-benchmark-cluster
5b42857
test-benchmark-cluster needs to account for an option added in 973f324.
PR-URL: #30342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@ZYSzysZYSzysZYSzys approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@lpinca@cjihrig@ZYSzys