Skip to content

console: remove non-existant methods from docs - #30346

Closed
SimonSchick wants to merge 1 commit into
nodejs:masterfrom
SimonSchick:docs/remove-dead-inspector-methods
Closed

console: remove non-existant methods from docs#30346
SimonSchick wants to merge 1 commit into
nodejs:masterfrom
SimonSchick:docs/remove-dead-inspector-methods

Conversation

@SimonSchick

Copy link
Copy Markdown
Contributor
Checklist

It seems these methods are not present anymore, not even with --inspect so I propose removing these docs.

@nodejs-github-botnodejs-github-bot added console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations. labels Nov 10, 2019
@SimonSchick
SimonSchickforce-pushed the docs/remove-dead-inspector-methods branch from 22703ab to 1bceb10CompareNovember 10, 2019 07:10
@SimonSchick
SimonSchickforce-pushed the docs/remove-dead-inspector-methods branch 2 times, most recently from df39117 to 8d29657CompareNovember 10, 2019 07:58
@SimonSchick

Copy link
Copy Markdown
ContributorAuthor

Fixed lint and commit message.

@SimonSchickSimonSchick changed the title docs, lib: remove non-existant methodsconsole: remove non-existant methods from docsNov 10, 2019
@lpinca

Copy link
Copy Markdown
Member

@SimonSchick I think doc: is more appropriate as subsystem in commit title.

@SimonSchick

Copy link
Copy Markdown
ContributorAuthor

Ah, I tried to use docs before but I guess it needs to be singular.

@SimonSchick
SimonSchickforce-pushed the docs/remove-dead-inspector-methods branch from 8d29657 to 5e7d211CompareNovember 10, 2019 08:43
@danbev

Copy link
Copy Markdown
Contributor

@danbevdanbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 12, 2019
danbev pushed a commit that referenced this pull request Nov 13, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danbev

Copy link
Copy Markdown
Contributor

Landed in 0e964a7.

@danbevdanbev closed this Nov 13, 2019
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeARBridgeAR mentioned this pull request Nov 19, 2019
targos pushed a commit that referenced this pull request Dec 1, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.consoleIssues and PRs related to the console subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@SimonSchick@lpinca@danbev@trivikr@nodejs-github-bot