Uh oh!
There was an error while loading. Please reload this page.
doc: document ICU time zone data update process - #30364
Closed
apaprocki wants to merge 1 commit into
Closed
Conversation
jasnell
approved these changes
Nov 12, 2019
devnexen
approved these changes
Nov 12, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vsemozhetbyt
commented
Nov 16, 2019
Contributor
It seems we have some linter issues (line length and list markers). |
mhdawson
commented
Nov 22, 2019
Member
@srl295 FYI if you can take a look. |
3 tasks
Member
although… @apaprocki could we merge this in to #30607 ? it could be subsection of the new |
BridgeAR
commented
Dec 25, 2019
Member
Ping @apaprocki |
1 similar comment
BridgeAR
commented
Jan 2, 2020
Member
Ping @apaprocki |
apaprocki
commented
Jan 2, 2020
ContributorAuthor
I’ll away, will be back next week and can look at this. |
BridgeAR
commented
Jan 12, 2020
Member
Ping @apaprocki |
apaprocki
commented
Jan 12, 2020
ContributorAuthor
@srl295 Took a stab at it, let me know if you'd like anything different. I just guessed where it might fit into the flow of the other file. |
srl295
commented
Jan 13, 2020
via email
Member
Looks great except drop the reference to “icu-small”
S
El El dom, ene. 12, 2020 a la(s) 12:10 p. m., Andrew Paprocki <
notifications@github.com> escribió: …@srl295 <https://github.com/srl295> Took a stab at it, let me know if
you'd like anything different. I just guessed where it might fit into the
flow of the other file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30364?email_source=notifications&email_token=AAGQZMZWXS3TRMR5GPSMGNLQ5N2LRA5CNFSM4JL42FLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIXC7GQ#issuecomment-573452186>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGQZM66ACWF3SOASVMRFZLQ5N2LRANCNFSM4JL42FLA>
.
|
Updates the "Maintaining ICU" document and describes the process to update an existing ICU `.dat` file with updated binary time zone data files corresponding to new IANA `tzdata` releases. Requested in nodejs#30211 by @srl295
srl295
approved these changes
May 11, 2020
nodejs-github-bot
commented
May 11, 2020
Collaborator
srl295
commented
May 11, 2020
Member
@apaprocki I'll work on landing this… it's passed the linter already so should be fine |
2 tasks
srl295
commented
May 19, 2020
Member
ahh - still need to land. |
srl295 pushed a commit
that referenced
this pull request
May 19, 2020
Updates the "Maintaining ICU" document and describes the process to update an existing ICU `.dat` file with updated binary time zone data files corresponding to new IANA `tzdata` releases. Requested in #30211 by @srl295 PR-URL: #30364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
srl295
commented
May 19, 2020
Member
Landed in fe1b9e0 |
codebytere pushed a commit
that referenced
this pull request
May 21, 2020
Updates the "Maintaining ICU" document and describes the process to update an existing ICU `.dat` file with updated binary time zone data files corresponding to new IANA `tzdata` releases. Requested in #30211 by @srl295 PR-URL: #30364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the "Maintaining ICU" document and describes the process
to update an existing ICU
.datfile with updated binary timezone data files corresponding to new IANA
tzdatareleases.Requested in #30211 by @srl295