Skip to content

doc: explain GIT_REMOTE_REF in COLLABORATOR_GUIDE - #30371

Closed
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:doc-mention-git-remote-ref
Closed

doc: explain GIT_REMOTE_REF in COLLABORATOR_GUIDE#30371
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:doc-mention-git-remote-ref

Conversation

@lundibundi

Copy link
Copy Markdown
Member

Adds short mention and examples for GIT_REMOTE_REF in COLLABORATOR_GUIDE.md considering I couldn't easily find this info when I wanted to make sure and the COLLABORATOR_GUIDE is where I assume people would look first.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 12, 2019
@BridgeAR

Copy link
Copy Markdown
Member

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
trivikr pushed a commit that referenced this pull request Nov 21, 2019
PR-URL: #30371
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@trivikr

Copy link
Copy Markdown
Member

Landed in c8d00d9

@trivikrtrivikr closed this Nov 21, 2019
MylesBorins pushed a commit that referenced this pull request Nov 21, 2019
PR-URL: #30371
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR mentioned this pull request Nov 21, 2019
targos pushed a commit that referenced this pull request Dec 1, 2019
PR-URL: #30371
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30371
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lundibundi@BridgeAR@trivikr@jasnell@lpinca@nodejs-github-bot