Skip to content

util: Use let instead of var for util/inspect.js - #30399

Closed
lmammino wants to merge 3 commits into
nodejs:masterfrom
lmammino:fix/removes-var-from-inspect
Closed

util: Use let instead of var for util/inspect.js#30399
lmammino wants to merge 3 commits into
nodejs:masterfrom
lmammino:fix/removes-var-from-inspect

Conversation

@lmammino

@lmamminolmammino commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Style changes: use let instead of var in lib/internal/util/inspect.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 12, 2019
@jasnelljasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@BridgeAR

BridgeAR commented Nov 13, 2019

Copy link
Copy Markdown
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4056/

@lmammino

lmammino commented Nov 14, 2019

Copy link
Copy Markdown
ContributorAuthor

Ci seems to be failing because the first letter (after subsystem) in my commit message is uppercase. I'll try to fix this with an amend commit...

@lmammino
lmamminoforce-pushed the fix/removes-var-from-inspect branch from 8c7a7df to a2dd360CompareNovember 14, 2019 15:41
@nodejs-github-bot

nodejs-github-bot commented Nov 16, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26616/

@gireeshpunathil

gireeshpunathil commented Nov 25, 2019

Copy link
Copy Markdown
Member

Linux-containered (ubuntu1804_sharedlibs_debug_x64): https://ci.nodejs.org/job/node-test-commit-linux-containered/16157/

@lmammino

lmammino commented Nov 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Still seeing some failures in the CI, can someone guide me on what's wrong and how to resolve any pending issue?

@gireeshpunathil

gireeshpunathil commented Nov 25, 2019

Copy link
Copy Markdown
Member

last run (linux-containerized) was aborted due to infra issues. new run:
https://ci.nodejs.org/job/node-test-commit-linux-containered/16165/

@gireeshpunathil

gireeshpunathil commented Nov 26, 2019

Copy link
Copy Markdown
Member

once again: https://ci.nodejs.org/job/node-test-commit-linux-containered/16217/

@gireeshpunathil

gireeshpunathil commented Nov 26, 2019

Copy link
Copy Markdown
Member

the linux-containerized failure parallel/test-domain-error-types is known as in #30498

gireeshpunathil pushed a commit that referenced this pull request Nov 26, 2019
@lmammino@gireeshpunathil
util: use let instead of var for util/inspect.js
3f59704
PR-URL: #30399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil

gireeshpunathil commented Nov 26, 2019

Copy link
Copy Markdown
Member

landed in 3f59704.

thanks for the contribution!

@lmammino

lmammino commented Nov 26, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank you all for helping me with this :)

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@lmammino@addaleax
util: use let instead of var for util/inspect.js
18e9b56
PR-URL: #30399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@lmammino@targos
util: use let instead of var for util/inspect.js
a4c404c
PR-URL: #30399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@lmammino@MylesBorins
util: use let instead of var for util/inspect.js
7421cc8
PR-URL: #30399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lmammino@BridgeAR@nodejs-github-bot@gireeshpunathil@jasnell@cjihrig@trivikr