Skip to content

http2: replace var with let/const - #30417

Closed
pc3b3r wants to merge 3 commits into
nodejs:masterfrom
pc3b3r:http2-const
Closed

http2: replace var with let/const#30417
pc3b3r wants to merge 3 commits into
nodejs:masterfrom
pc3b3r:http2-const

Conversation

@pc3b3r

@pc3b3rpc3b3r commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Changed var to let and const on util. Keeping var on for loops.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Nov 12, 2019
@jasnelljasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
Comment threadlib/internal/http2/util.js Outdated
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
Comment threadlib/internal/http2/util.js Outdated
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
Comment threadlib/internal/http2/util.js Outdated
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
Comment threadlib/internal/http2/util.js Outdated
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
Comment threadlib/internal/http2/util.js Outdated
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
Comment threadlib/internal/http2/util.js Outdated
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
Comment threadlib/internal/http2/util.js Outdated
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
Comment threadlib/internal/http2/util.js Outdated
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
Comment threadlib/internal/http2/util.js Outdated
@pc3b3r@jasnell
Apply suggestions from code review
c04da8c
Co-Authored-By: James M Snell <jasnell@gmail.com>
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
Comment threadlib/internal/http2/util.js Outdated
@pc3b3r@jasnell
Update lib/internal/http2/util.js
ace8b68
Co-Authored-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26553/

@nodejs-github-bot

nodejs-github-bot commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26782/

@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26874/

Trott pushed a commit that referenced this pull request Nov 23, 2019
@pc3b3r@Trott
http2: replace var with let/const
0271f1b
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott

Trott commented Nov 23, 2019

Copy link
Copy Markdown
Member

Landed in 0271f1b.

Thanks for the contribution! 🎉

@TrottTrott closed this Nov 23, 2019
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@pc3b3r@addaleax
http2: replace var with let/const
f7ca7e6
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@pc3b3r@targos
http2: replace var with let/const
2a44ff5
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@pc3b3r@MylesBorins
http2: replace var with let/const
bccef49
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pc3b3r@nodejs-github-bot@Trott@jasnell@gireeshpunathil@BridgeAR@trivikr