Skip to content

test: change object assign to spread object in test/parallel/test-npm-install.js - #30422

Closed
putxe wants to merge 3 commits into
nodejs:masterfrom
putxe:nceu2019-object-assign-to-spread
Closed

test: change object assign to spread object in test/parallel/test-npm-install.js#30422
putxe wants to merge 3 commits into
nodejs:masterfrom
putxe:nceu2019-object-assign-to-spread

Conversation

@putxe

@putxeputxe commented Nov 12, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 12, 2019
@addaleaxaddaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
trivikr
trivikr approved these changes Nov 13, 2019
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadtest/parallel/test-npm-install.js
NPM_CONFIG_TMP: path.join(npmSandbox,'npm-tmp'),
HOME: homeDir,
});
constenv={ ...process.env,

@trivikrtrivikrNov 13, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can be made more readable as follows:

constenv={
...process.env,PATH: path.dirname(process.execPath),NPM_CONFIG_PREFIX: path.join(npmSandbox,'npm-prefix'),NPM_CONFIG_TMP: path.join(npmSandbox,'npm-tmp'),HOME: homeDir};

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26940/

@gireeshpunathil

gireeshpunathil commented Nov 25, 2019

Copy link
Copy Markdown
Member

the only failure parallel/test-domain-error-types is known as in #30498

gireeshpunathil pushed a commit that referenced this pull request Nov 25, 2019
@putxe@gireeshpunathil
test: change object assign to spread object
ce4f97c
change object assign to spread object in test-npm-install.js
PR-URL: #30422
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil

gireeshpunathil commented Nov 25, 2019

Copy link
Copy Markdown
Member

landed in ce4f97c

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@putxe@addaleax
test: change object assign to spread object
e401e8c
change object assign to spread object in test-npm-install.js
PR-URL: #30422
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@putxe@targos
test: change object assign to spread object
8a0d1cb
change object assign to spread object in test-npm-install.js
PR-URL: #30422
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@putxe@MylesBorins
test: change object assign to spread object
01da702
change object assign to spread object in test-npm-install.js
PR-URL: #30422
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@putxe@nodejs-github-bot@gireeshpunathil@jasnell@addaleax@lpinca@cjihrig@BridgeAR@trivikr