Uh oh!
There was an error while loading. Please reload this page.
test: change from var to let - #30431
Closed
Sahtair wants to merge 2 commits into
Closed
Conversation
cjihrig
approved these changes
Nov 12, 2019
targos
requested changes
Nov 12, 2019
targos
left a comment
Member
There was a problem hiding this comment.
This is not valid JavaScript, because constants must be initialized where they are declared.
You can change them to let instead.
jasnell
approved these changes
Nov 12, 2019
trivikr
approved these changes
Nov 13, 2019
gireeshpunathil
approved these changes
Nov 17, 2019
targos
approved these changes
Nov 17, 2019
nodejs-github-bot
commented
Nov 18, 2019
Collaborator
gireeshpunathil pushed a commit
that referenced
this pull request
Nov 18, 2019
PR-URL: #30431 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gireeshpunathil
commented
Nov 18, 2019
Member
landed in 0bc0abb, thanks for the contribution! |
BridgeAR pushed a commit
that referenced
this pull request
Nov 19, 2019
PR-URL: #30431 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30431 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30431 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes