Uh oh!
There was an error while loading. Please reload this page.
Change var declarations to let and const - #30445
Closed
Xavier-Redondo wants to merge 2 commits into
Closed
Conversation
addaleax
approved these changes
Nov 12, 2019
alexahdp
approved these changes
Nov 12, 2019
trivikr
commented
Nov 13, 2019
Member
|
BridgeAR
approved these changes
Nov 13, 2019
nodejs-github-bot
commented
Nov 13, 2019
Collaborator
BridgeAR
commented
Nov 13, 2019
Member
@trivikr I believe it should not cause any issues to merge the other PR first and to land this afterwards. If the changes are identical, there should not be any conflicts. |
jasnell
approved these changes
Nov 14, 2019
gireeshpunathil
approved these changes
Nov 17, 2019
nodejs-github-bot
commented
Nov 17, 2019
Collaborator
gireeshpunathil pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gireeshpunathil
commented
Nov 17, 2019
Member
landed in b6c407b , thanks for the contribution! |
BridgeAR pushed a commit
that referenced
this pull request
Nov 19, 2019
PR-URL: #30445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) *make -j4 test-onlybecausemake -j4 testgave error related to test-doc. this happened before and after making my changes.