Skip to content

benchmark: use let instead of var in assert - #30450

Closed
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:fix_benchmark_assert
Closed

benchmark: use let instead of var in assert#30450
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:fix_benchmark_assert

Conversation

@dnlup

@dnlupdnlup commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Use let instead of var in benchmark/assert/deepequal-buffer.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Nov 12, 2019
@addaleaxaddaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
@dnlup
dnlupforce-pushed the fix_benchmark_assert branch from 585c821 to 350075cCompareNovember 12, 2019 18:56
@dnlupdnlup mentioned this pull request Nov 12, 2019
Closed
2 tasks
@dnlupdnlup changed the title benchmark: use let instead of var in assert[WIP] benchmark: use let instead of var in assertNov 12, 2019
@dnlup
dnlupforce-pushed the fix_benchmark_assert branch from 350075c to 294c7d6CompareNovember 12, 2019 19:13
@dnlupdnlup changed the title [WIP] benchmark: use let instead of var in assertbenchmark: use let instead of var in assertNov 12, 2019
trivikr
trivikr approved these changes Nov 13, 2019
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits

Comment threadbenchmark/assert/deepequal-map.js Outdated
Comment threadbenchmark/assert/deepequal-set.js Outdated
Comment threadbenchmark/assert/ok.js Outdated
Comment threadbenchmark/assert/throws.js Outdated
@SimonSchick

SimonSchick commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Going slightly out of scope.
@trivikr if I was to submit a PR that changed allfor(regular/in/of) loops to let/const respectively, would this be accepted?

@dnlup
dnlupforce-pushed the fix_benchmark_assert branch from 294c7d6 to 769540aCompareNovember 13, 2019 16:22
@trivikr

trivikr commented Nov 13, 2019•
edited
Loading

Copy link
Copy Markdown
Member

if I was to submit a PR that changed all for(regular/in/of) loops to let/const respectively, would this be accepted?

@SimonSchick Short answer is most likely "No"

This is one of the Code and Learn tasks from workshop at NodeConfEU:

  • Label for other PRs code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.
  • Conference schedule https://www.nodeconf.eu/schedule/
    • Workshop was conducted at 1400 hours UTC+00:00 on Monday, November 11, 2019

There are many other PRs which are doing var to let/const replacements in other files.
If you are interested, please wait for some time (say a month) for all those PRs to be merged, and then create your PR. Other options:

  • go through all open code-and-learn PRs to find out which files are not touched
  • ping NodeConfEU code-and-learn organizers @jasnell / @addaleax / @BridgeAR to find files which are yet to be updated.

I don't recommend doing it for all files at once it'l be difficult to review. For example, we still use var at some places for:

I think you can replace vs to let/const on module basis (one PR for http, one for fs etc) so that only the particular module team can review it.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26547/

@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26644/

gireeshpunathil pushed a commit that referenced this pull request Nov 17, 2019
@dnlup@gireeshpunathil
benchmark: use let instead of var in assert
d1ce04c
PR-URL: #30450
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil

gireeshpunathil commented Nov 17, 2019

Copy link
Copy Markdown
Member

landed in d1ce04c , thanks for the contribution!

BridgeAR pushed a commit that referenced this pull request Nov 19, 2019
@dnlup@BridgeAR
benchmark: use let instead of var in assert
0130d2b
PR-URL: #30450
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeARBridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@dnlup@targos
benchmark: use let instead of var in assert
7d113af
PR-URL: #30450
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@dnlup@MylesBorins
benchmark: use let instead of var in assert
351ee64
PR-URL: #30450
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
@dnlup
dnlup deleted the fix_benchmark_assert branch January 10, 2020 13:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dnlup@SimonSchick@trivikr@nodejs-github-bot@gireeshpunathil@addaleax@devnexen@BridgeAR