Skip to content

buffer: fix 6-byte writeUIntBE() range check - #30459

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:buffer-fix-writeuintbe-6
Closed

buffer: fix 6-byte writeUIntBE() range check#30459
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:buffer-fix-writeuintbe-6

Conversation

@mscdex

@mscdexmscdex commented Nov 13, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #30420

CI: https://ci.nodejs.org/job/node-test-pull-request/26530/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdexmscdex added the buffer Issues and PRs related to the buffer subsystem. label Nov 13, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26530/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26535/

@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27171/

@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27195/

Trott pushed a commit that referenced this pull request Nov 30, 2019
@mscdex@Trott
buffer: fix 6-byte writeUIntBE() range check
c14c476
Fixes: #30420
PR-URL: #30459
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

Trott commented Nov 30, 2019

Copy link
Copy Markdown
Member

Landed in c14c476

@TrottTrott closed this Nov 30, 2019
@mscdex
mscdex deleted the buffer-fix-writeuintbe-6 branch November 30, 2019 04:15
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@mscdex@addaleax
buffer: fix 6-byte writeUIntBE() range check
63eb4fe
Fixes: #30420
PR-URL: #30459
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
@mscdex@targos
buffer: fix 6-byte writeUIntBE() range check
f0d4392
Fixes: #30420
PR-URL: #30459
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@mscdex@MylesBorins
buffer: fix 6-byte writeUIntBE() range check
719e33f
Fixes: #30420
PR-URL: #30459
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+2 more reviewers
@SimonSchickSimonSchickSimonSchick approved these changes
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

writeUIntBE() method does not throw range error for 48bit

9 participants

@mscdex@nodejs-github-bot@Trott@jasnell@addaleax@cjihrig@SimonSchick@devnexen@BridgeAR