Skip to content

[12.x] tools: update tzdata to 2019c - #30478

Closed
MylesBorins wants to merge 1 commit into
nodejs:v12.x-stagingfrom
MylesBorins:update-icu-12.x
Closed

[12.x] tools: update tzdata to 2019c#30478
MylesBorins wants to merge 1 commit into
nodejs:v12.x-stagingfrom
MylesBorins:update-icu-12.x

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Refs: #30211
Refs: #30356

@MylesBorinsMylesBorins changed the title tools: update tzdata to 2019c[12.x] tools: update tzdata to 2019cNov 13, 2019
srl295
srl295 approved these changes Nov 13, 2019
View reviewed changes

@srl295srl295 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM…

@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26573/

@MylesBorinsMylesBorins mentioned this pull request Nov 13, 2019
Merged
@MylesBorins

MylesBorins commented Nov 13, 2019

Copy link
Copy Markdown
ContributorAuthor

Could we please fast-track this

@MylesBorinsMylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 13, 2019
@targos

targos commented Nov 14, 2019

Copy link
Copy Markdown
Member

Landed in 2810f1a

@targostargos closed this Nov 14, 2019
targos pushed a commit that referenced this pull request Nov 14, 2019
@MylesBorins@targos
tools: update tzdata to 2019c
2810f1a
Refs: #30211
Refs: #30356
PR-URL: #30478
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295srl295srl295 approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MylesBorins@nodejs-github-bot@targos@srl295@cjihrig