Skip to content

doc: adds assert doc for strict mode with pointer to strict equality - #30486

Closed
shobhitchittora wants to merge 3 commits into
nodejs:masterfrom
shobhitchittora:doc-strict-mode
Closed

doc: adds assert doc for strict mode with pointer to strict equality#30486
shobhitchittora wants to merge 3 commits into
nodejs:masterfrom
shobhitchittora:doc-strict-mode

Conversation

@shobhitchittora

@shobhitchittorashobhitchittora commented Nov 14, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds a note to not confuse strict mode in assert module with JS "use strict" directive.

Refs: #30485

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Nov 14, 2019
BridgeAR
BridgeAR reviewed Nov 14, 2019
View reviewed changes
Comment threaddoc/api/assert.md Outdated
Comment threaddoc/api/assert.md Outdated
@shobhitchittora

shobhitchittora commented Nov 15, 2019

Copy link
Copy Markdown
ContributorAuthor

@BridgeAR My bad! Just clicked on re-review. 😛

@nodejs-github-bot

nodejs-github-bot commented Nov 16, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26628/

@nodejs-github-bot

nodejs-github-bot commented Nov 22, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26828/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27118/

@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27170/

@cjihrig

cjihrig commented Nov 29, 2019

Copy link
Copy Markdown
Contributor

I killed the CI run since it had been running for over 6 hours. Since this is a doc only PR, it doesn't need a full CI run anyway.

cc: @nodejs/build

addaleax pushed a commit that referenced this pull request Dec 3, 2019
@shobhitchittora@addaleax
doc: adds assert doc for strict mode with pointer to strict equality
dbdad4d
Refs: #30485
PR-URL: #30486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@addaleax

addaleax commented Dec 3, 2019

Copy link
Copy Markdown
Member

Landed in dbdad4d

@addaleaxaddaleax closed this Dec 3, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@shobhitchittora@targos
doc: adds assert doc for strict mode with pointer to strict equality
2c0f1ed
Refs: #30485
PR-URL: #30486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@shobhitchittora@targos
doc: adds assert doc for strict mode with pointer to strict equality
ffad436
Refs: #30485
PR-URL: #30486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@shobhitchittora@BethGriggs
doc: adds assert doc for strict mode with pointer to strict equality
420d793
Refs: #30485
PR-URL: #30486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
@shobhitchittorashobhitchittora mentioned this pull request Apr 5, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@trivikrtrivikrtrivikr approved these changes
@BridgeARBridgeARAwaiting requested review from BridgeAR

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@shobhitchittora@nodejs-github-bot@cjihrig@addaleax@lpinca@gireeshpunathil@BridgeAR@trivikr