[v10.x]: Backport instance data by gabrielschulhof · Pull Request #30537 · nodejs/node

gabrielschulhof · 2019-11-18T21:52:55Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

gabrielschulhof · 2019-11-18T21:53:59Z

nodejs-github-bot · 2019-11-27T02:42:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27062/

mhdawson · 2019-11-27T21:56:16Z

@gabrielf I assume the commit did not apply cleanly. Can you identify the parts you had to update in order to limit what we need to review?

gabrielschulhof · 2019-12-03T05:11:41Z

@mhdawson the separation of js_native_api from node_api is not present in this version, so backporting is not straight-forward. The napi_env in this version is not broken into node_napi_env and napi_env. So, the parts modifying napi_env are the most relevant. Yet the places from which NapiCallIntoModule is being performed had to be updated manually as well, because the files were not separated into node_api and js_native_api, like on master.

nodejs-github-bot · 2019-12-03T10:29:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27302/

gabrielschulhof · 2019-12-04T00:57:41Z

Rebased.

nodejs-github-bot · 2019-12-04T01:00:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27321/

nodejs-github-bot · 2019-12-05T03:04:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27337/

nodejs-github-bot · 2019-12-05T05:23:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27342/

gabrielschulhof · 2019-12-05T23:42:07Z

Rebased again.

nodejs-github-bot · 2019-12-05T23:43:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27368/

nodejs-github-bot · 2019-12-06T02:10:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27383/

gabrielschulhof · 2019-12-08T04:20:14Z

Rebased again.

nodejs-github-bot · 2019-12-08T04:22:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27475/

nodejs-github-bot · 2019-12-08T21:29:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27503/

These do not need to be macros. PR-URL: nodejs#26128 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Adds `napi_set_instance_data()` and `napi_get_instance_data()`, which allow native addons to store their data on and retrieve their data from `napi_env`. `napi_set_instance_data()` accepts a finalizer which is called when the `node::Environment()` is destroyed. This entails rendering the `napi_env` local to each add-on. Fixes: nodejs/abi-stable-node#378 PR-URL: nodejs#28682 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs-github-bot · 2019-12-18T19:50:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27790/

nodejs-github-bot · 2019-12-18T22:04:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27797/

nodejs-github-bot · 2019-12-19T04:16:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27803/

gabrielschulhof · 2019-12-19T05:11:39Z

@BethGriggs can we get this into v10.x before it goes into maintenance?

BethGriggs · 2019-12-19T10:38:37Z

@gabrielschulhof, yes - we're aiming to have one more semver-minor release in Q1 2020 (probably late Jan/Feb time), I'll land this commit in staging once v10.18.1 has gone out - #30796

gabrielschulhof · 2020-02-15T05:40:07Z

@BethGriggs is this still on track to land?

BethGriggs · 2020-02-19T16:03:37Z

@gabrielschulhof yes, but I'm unsure on the timing of the release (nodejs/Release#504 needs updating).

nodejs-github-bot · 2020-02-19T20:31:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29244/

nodejs-github-bot · 2020-02-24T17:57:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29318/

BethGriggs · 2020-02-24T18:10:13Z

Possibly will not get a green CI on this until #31887 lands (@AshCripps and I are currently working on backporting the appropriate flaky test markers from v12.x)

nodejs-github-bot · 2020-02-25T15:41:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29347/ ✅ (Known flake)

These do not need to be macros. PR-URL: #26128 Backport-PR-URL: #30537 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Adds `napi_set_instance_data()` and `napi_get_instance_data()`, which allow native addons to store their data on and retrieve their data from `napi_env`. `napi_set_instance_data()` accepts a finalizer which is called when the `node::Environment()` is destroyed. This entails rendering the `napi_env` local to each add-on. Fixes: nodejs/abi-stable-node#378 PR-URL: #28682 Backport-PR-URL: #30537 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BethGriggs · 2020-02-25T20:03:44Z

Landed in 3f9cec3...f29fb14

gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Nov 18, 2019

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v10.x labels Nov 18, 2019

gabrielschulhof requested a review from addaleax November 18, 2019 21:53

gabrielschulhof added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 18, 2019

gabrielschulhof changed the title ~~v10.x: Backport instance data~~[v10.x]: Backport instance dataNov 19, 2019

gengjiawen approved these changes Nov 20, 2019
View reviewed changes

gabrielschulhof force-pushed the backport-instance-data branch from c15919b to 6911a3fCompare December 4, 2019 00:57

gabrielschulhof force-pushed the backport-instance-data branch from 6911a3f to e73f742Compare December 5, 2019 23:41

gabrielschulhof force-pushed the backport-instance-data branch from e73f742 to 24eb78bCompare December 8, 2019 04:10

MylesBorins force-pushed the v10.x-staging branch from 99915bc to 8f3b8caCompare December 17, 2019 22:08

addaleaxand others added 2 commits December 18, 2019 11:46

n-api: turn NAPI_CALL_INTO_MODULE into a function
09776ba
These do not need to be macros. PR-URL: nodejs#26128 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

gabrielschulhof force-pushed the backport-instance-data branch from 24eb78b to dc7d5fdCompare December 18, 2019 19:47

gabrielschulhof mentioned this pull request Jan 8, 2020
v10.18.1 proposal #31248
Merged

BethGriggs approved these changes Jan 14, 2020
View reviewed changes

gabrielschulhof mentioned this pull request Jan 19, 2020
Best practice to store context-aware class constructor reference nodejs/node-addon-api#654
Closed

gabrielschulhof mentioned this pull request Feb 15, 2020
[v10.x] Backport large pages to v10.x #31105
Closed
4 tasks

This comment has been minimized.
Sign in to view

BethGriggs pushed a commit that referenced this pull request Feb 25, 2020
n-api: turn NAPI_CALL_INTO_MODULE into a function
20177b9
These do not need to be macros. PR-URL: #26128 Backport-PR-URL: #30537 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs closed this Feb 25, 2020

gabrielschulhof deleted the backport-instance-data branch April 21, 2020 02:58

Uh oh!

Uh oh!

Conversation

gabrielschulhof commented Nov 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

gabrielschulhof commented Nov 18, 2019

Uh oh!

nodejs-github-bot commented Nov 27, 2019

Uh oh!

mhdawson commented Nov 27, 2019

Uh oh!

gabrielschulhof commented Dec 3, 2019

Uh oh!

nodejs-github-bot commented Dec 3, 2019

Uh oh!

gabrielschulhof commented Dec 4, 2019

Uh oh!

nodejs-github-bot commented Dec 4, 2019

Uh oh!

nodejs-github-bot commented Dec 5, 2019

Uh oh!

nodejs-github-bot commented Dec 5, 2019

Uh oh!

gabrielschulhof commented Dec 5, 2019

Uh oh!

nodejs-github-bot commented Dec 5, 2019

Uh oh!

nodejs-github-bot commented Dec 6, 2019

Uh oh!

gabrielschulhof commented Dec 8, 2019

Uh oh!

nodejs-github-bot commented Dec 8, 2019

Uh oh!

nodejs-github-bot commented Dec 8, 2019

Uh oh!

nodejs-github-bot commented Dec 18, 2019

Uh oh!

nodejs-github-bot commented Dec 18, 2019

Uh oh!

nodejs-github-bot commented Dec 19, 2019

Uh oh!

gabrielschulhof commented Dec 19, 2019

Uh oh!

BethGriggs commented Dec 19, 2019

Uh oh!

gabrielschulhof commented Feb 15, 2020

Uh oh!

BethGriggs commented Feb 19, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 19, 2020

Uh oh!

nodejs-github-bot commented Feb 24, 2020

Uh oh!

BethGriggs commented Feb 24, 2020

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Feb 25, 2020• edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BethGriggs commented Feb 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gabrielschulhof commented Nov 18, 2019•
edited
Loading

BethGriggs commented Feb 19, 2020•
edited
Loading

nodejs-github-bot commented Feb 25, 2020•
edited by BethGriggs
Loading