Uh oh!
There was an error while loading. Please reload this page.
test: add test for options validation of createServer - #30541
Closed
ZYSzys wants to merge 2 commits into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Nov 19, 2019
Collaborator
lpinca
approved these changes
Nov 19, 2019
BridgeAR
approved these changes
Nov 19, 2019
cjihrig
approved these changes
Nov 20, 2019
ZYSzys added a commit
that referenced
this pull request
Nov 21, 2019
PR-URL: #30541 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ZYSzys added a commit
that referenced
this pull request
Nov 21, 2019
PR-URL: #30541 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ZYSzys
commented
Nov 21, 2019
MemberAuthor
Landed in 8138e9c...a7c13cf. |
MylesBorins pushed a commit
that referenced
this pull request
Nov 21, 2019
PR-URL: #30541 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 21, 2019
PR-URL: #30541 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30541 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30541 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30541 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30541 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: add test for options validation of
http2.createServerand
http2.createSecureServerhttp2: remove duplicated assertIsObject
We have invoke
initializeOptions(options)inHttp2ServerandHttp2SecureServer's constructor, and we doassertIsObject(options, 'options')ininitializeOptions(options), so theassertIsObject(options, 'options')increateServerandcreateSecureServerare duplicated.node/lib/internal/http2/core.js
Lines 2765 to 2766 in c1f0e80
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes