Skip to content

doc: add missing 'added' versions to module.builtinModules - #30562

Closed
watson wants to merge 1 commit into
nodejs:masterfrom
watson:builtin
Closed

doc: add missing 'added' versions to module.builtinModules#30562
watson wants to merge 1 commit into
nodejs:masterfrom
watson:builtin

Conversation

@watson

Copy link
Copy Markdown
Member

This was backported later, but the documentation wasn't updated.

Checklist

@watsonwatson added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 20, 2019
@watsonwatson self-assigned this Nov 20, 2019
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Nov 20, 2019
@watson

Copy link
Copy Markdown
MemberAuthor

Please upvote if we should fast-track this

@watsonwatson added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 20, 2019
@watson

Copy link
Copy Markdown
MemberAuthor

Force pushed as I was off by one on the 6.x branch because I couldn't read (wrote 6.13.1 instead of 6.13.0). For reference, here's the PR that was backported: #16386

addaleax pushed a commit that referenced this pull request Nov 30, 2019
PR-URL: #30562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@addaleax

Copy link
Copy Markdown
Member

Landed in ab2afa3

addaleax pushed a commit that referenced this pull request Nov 30, 2019
PR-URL: #30562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@watson
watson deleted the builtin branch December 2, 2019 10:20
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
targos pushed a commit that referenced this pull request Dec 5, 2019
PR-URL: #30562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.moduleIssues and PRs related to the module subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@watson@addaleax@lpinca@cjihrig@BethGriggs@nodejs-github-bot