Skip to content

tools: sync gyp code base with node-gyp repo - #30563

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:sync-gyp
Closed

tools: sync gyp code base with node-gyp repo#30563
targos wants to merge 1 commit into
nodejs:masterfrom
targos:sync-gyp

Conversation

@targos

@targostargos commented Nov 20, 2019

Copy link
Copy Markdown
Member

This syncs the gyp code base so that it is identical to the one in nodejs/node-gyp.

This was done by removing the code in nodejs/node-gyp, copying from nodejs/node and then manually reviewing and adapting the diff.

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Nov 20, 2019
@targostargos mentioned this pull request Nov 20, 2019
Merged
@targos

targos commented Nov 20, 2019

Copy link
Copy Markdown
MemberAuthor

PR in nodejs/node-gyp: nodejs/node-gyp#1975

@targos
targos requested a review from cclaussNovember 20, 2019 19:07
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26876/

@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26878/

ryzokuken
ryzokuken approved these changes Nov 26, 2019
View reviewed changes

@ryzokukenryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully I've seen everything, just a bunch of comments. Likely all the issues need to be picked up in the gyp3 repo instead, so feel free to ignore 'em and merge. Thanks for doing this!

Comment threadtools/gyp/pylib/gyp/MSVSVersion.py Outdated
Comment threadtools/gyp/pylib/gyp/common.py Outdated
Comment threadtools/gyp/gyp_main.py Outdated
Comment threadtools/gyp/pylib/gyp/common.py Outdated
Comment threadtools/gyp/gyp_main.py Outdated
Comment threadtools/gyp/pylib/gyp/input.py Outdated
cclauss
cclauss reviewed Nov 27, 2019
View reviewed changes
Comment threadtools/gyp/pylib/gyp/input.py Outdated
cclauss
cclauss reviewed Nov 27, 2019
View reviewed changes
Comment threadtools/gyp/pylib/gyp/xcode_emulation.py Outdated
@cclauss

cclauss commented Nov 27, 2019

Copy link
Copy Markdown
Contributor

Do we really want to get rid of tools/gyp/gyptest.py? Perhaps it should be renamed to tools/gyp/test_gyp.py so that pytest will discover it and modify it to run in our test cycles.

@targos

targos commented Nov 27, 2019

Copy link
Copy Markdown
MemberAuthor

@cclauss, that file was removed in nodejs/node-gyp#1458

@targostargos mentioned this pull request Dec 1, 2019
Closed
2 tasks
@nodejs-github-bot

nodejs-github-bot commented Dec 2, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27266/

BridgeAR
BridgeAR approved these changes Dec 24, 2019
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 24, 2019
@nodejs-github-bot

nodejs-github-bot commented Dec 24, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27918/

@ryzokuken

ryzokuken commented Dec 24, 2019

Copy link
Copy Markdown
Contributor

@targos what's left to be addressed here?

@targostargos added the blocked PRs that are blocked by other issues or PRs. label Dec 25, 2019
@targos

targos commented Dec 25, 2019

Copy link
Copy Markdown
MemberAuthor

@ryzokukennodejs/node-gyp#1975 (comment) and nodejs/node-gyp#1975 (review)

Trott
Trott approved these changes Dec 31, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once unblocked

@TrottTrott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 4, 2020
@richardlaurichardlau mentioned this pull request Jan 29, 2020
Closed
4 tasks
@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28776/

@richardlaurichardlau mentioned this pull request Feb 10, 2020
Closed
@rvaggrvagg mentioned this pull request Feb 11, 2020
Closed
@targostargos removed the blocked PRs that are blocked by other issues or PRs. label Feb 19, 2020
@targos

targos commented Feb 19, 2020

Copy link
Copy Markdown
MemberAuthor

Other PR landed on node-gyp. This should be ready to go.

@nodejs-github-bot

nodejs-github-bot commented Feb 19, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29233/

targos added a commit that referenced this pull request Feb 21, 2020
@targos
tools: sync gyp code base with node-gyp repo
cf00961
PR-URL: #30563
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos

targos commented Feb 21, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in cf00961

@targostargos closed this Feb 21, 2020
@targos
targos deleted the sync-gyp branch February 21, 2020 10:12
@sthagensthagen mentioned this pull request Feb 21, 2020
Merged
4 tasks
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@targos@codebytere
tools: sync gyp code base with node-gyp repo
79b1f04
PR-URL: #30563
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gengjiawengengjiawen mentioned this pull request Feb 29, 2020
Closed
63 tasks
@codebyterecodebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@targos@codebytere
tools: sync gyp code base with node-gyp repo
e8630b0
PR-URL: #30563
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@targos@codebytere
tools: sync gyp code base with node-gyp repo
15b1597
PR-URL: #30563
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@targos@codebytere
tools: sync gyp code base with node-gyp repo
aa8a435
PR-URL: #30563
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BaochengSu pushed a commit to BaochengSu/node that referenced this pull request Oct 20, 2020
@targos@BaochengSu
tools: sync gyp code base with node-gyp repo
21ae071
PR-URL: nodejs#30563
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@cclausscclausscclauss approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@ryzokukenryzokukenryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@cclauss@ryzokuken@Trott@BridgeAR