Skip to content

doc: add 13 and 12 to previous versions - #30590

Closed
andrewhughes101 wants to merge 1 commit into
nodejs:masterfrom
andrewhughes101:patch-1
Closed

doc: add 13 and 12 to previous versions#30590
andrewhughes101 wants to merge 1 commit into
nodejs:masterfrom
andrewhughes101:patch-1

Conversation

@andrewhughes101

Copy link
Copy Markdown
Contributor

Remove Node.js 6 and add Node.js 12 and Node.js 13 to the previous versions of this document section

Checklist

Remove Node.js 6 and add Node.js 12 and Node.js 13 to the previous versions of this document section
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 22, 2019
@gireeshpunathil

Copy link
Copy Markdown
Member

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Nov 27, 2019
Remove Node.js 6 and add Node.js 12 and Node.js 13 to the previous
versions of this document section
PR-URL: #30590
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins

Copy link
Copy Markdown
Contributor

Landed in 7f94fe0

Single travis failure was for commit message, I fixed this while landing.

addaleax pushed a commit that referenced this pull request Nov 30, 2019
Remove Node.js 6 and add Node.js 12 and Node.js 13 to the previous
versions of this document section
PR-URL: #30590
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
Remove Node.js 6 and add Node.js 12 and Node.js 13 to the previous
versions of this document section
PR-URL: #30590
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
Remove Node.js 6 and add Node.js 12 and Node.js 13 to the previous
versions of this document section
PR-URL: #30590
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@andrewhughes101@gireeshpunathil@MylesBorins@addaleax@cjihrig@gengjiawen@richardlau@BethGriggs@mhdawson@trivikr@nodejs-github-bot