Skip to content

tools: update ESLint to 6.7.1 - #30598

Merged
cjihrig merged 2 commits into
nodejs:masterfrom
cjihrig:eslint
Nov 25, 2019
Merged

tools: update ESLint to 6.7.1#30598
cjihrig merged 2 commits into
nodejs:masterfrom
cjihrig:eslint

Conversation

@cjihrig

@cjihrigcjihrig commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

This also enables a handful of new ESLint rules that were added in 6.7.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 22, 2019
@cjihrigcjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 22, 2019
@cjihrigcjihrig changed the title tools: update ESLint to 6.7.0tools: update ESLint to 6.7.1Nov 25, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26945/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26952/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26961/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26963/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26965/

@cjihrig

cjihrig commented Nov 25, 2019

Copy link
Copy Markdown
ContributorAuthor

There is one remaining failure on ubuntu1804_sharedlibs_shared_x64:

11:22:55 not ok 2591 node-api/test_make_callback/test-async-hooks-gcable
11:22:55 ---
11:22:55 duration_ms: 0.267
11:22:55 severity: crashed
11:22:55 exitcode: -11
11:22:55 stack: |-
11:22:55 ...

That test has failed on a few runs now, including in other PRs (https://ci.nodejs.org/job/node-test-commit-linux-containered/16163/). Since an ESLint update is unlikely to cause this failure, and because it's showing up elsewhere, I'm going to move forward with landing this.

@cjihrig
tools: update ESLint to 6.7.1
90fb308
Update ESLint to 6.7.1
PR-URL: nodejs#30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig
tools: enable more eslint rules
a50cc2e
This commit enables these new in ESLint 6.7.0 rules:
- no-constructor-return
- no-dupe-else-if
- no-setter-return
PR-URL: nodejs#30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig
cjihrig merged commit a50cc2e into nodejs:masterNov 25, 2019
@cjihrig

cjihrig commented Nov 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Landed in 02d4c74...a50cc2e.

@cjihrig
cjihrig deleted the eslint branch November 25, 2019 16:58
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@cjihrig@addaleax
tools: update ESLint to 6.7.1
5522467
Update ESLint to 6.7.1
PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@cjihrig@addaleax
tools: enable more eslint rules
84f7b5c
This commit enables these new in ESLint 6.7.0 rules:
- no-constructor-return
- no-dupe-else-if
- no-setter-return
PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@cjihrig@targos
tools: update ESLint to 6.7.1
701a1d5
Update ESLint to 6.7.1
PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@cjihrig@targos
tools: enable more eslint rules
d9d6da4
This commit enables these new in ESLint 6.7.0 rules:
- no-constructor-return
- no-dupe-else-if
- no-setter-return
PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@cjihrig@MylesBorins
tools: update ESLint to 6.7.1
bce0880
Update ESLint to 6.7.1
PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@cjihrig@MylesBorins
tools: enable more eslint rules
df91d5f
This commit enables these new in ESLint 6.7.0 rules:
- no-constructor-return
- no-dupe-else-if
- no-setter-return
PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig@nodejs-github-bot@lpinca@targos@trivikr