Skip to content

module: fix dynamic import from eval - #30624

Closed
coreyfarrell wants to merge 2 commits into
nodejs:masterfrom
coreyfarrell:eval-dynamic-import
Closed

module: fix dynamic import from eval#30624
coreyfarrell wants to merge 2 commits into
nodejs:masterfrom
coreyfarrell:eval-dynamic-import

Conversation

@coreyfarrell

@coreyfarrellcoreyfarrell commented Nov 24, 2019

Copy link
Copy Markdown
Member

This allows dynamic import to work from CLI --eval with or without
--input-type=module.

Fixes: #30591

Checklist

@nodejs-github-botnodejs-github-bot added the process Issues and PRs related to the process subsystem. label Nov 24, 2019
yorkie
yorkie reviewed Nov 25, 2019
View reviewed changes
Comment threadlib/internal/modules/esm/loader.js Outdated
yorkie
yorkie approved these changes Nov 25, 2019
View reviewed changes

@yorkieyorkie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorinsMylesBorins added the esm Issues and PRs related to the ECMAScript Modules implementation. label Nov 27, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27066/

@coreyfarrell

coreyfarrell commented Nov 27, 2019

Copy link
Copy Markdown
MemberAuthor

I'm not sure what to do here, it doesn't look like the crash is caused by my change?

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
bcoe
bcoe reviewed Nov 30, 2019
View reviewed changes
Comment threadlib/internal/process/execution.js Outdated
bcoe
bcoe suggested changes Nov 30, 2019
View reviewed changes
Comment threadlib/internal/process/execution.js Outdated
Comment threadlib/internal/process/execution.js Outdated
@guybedford
guybedford requested a review from bcoeDecember 5, 2019 05:08
bcoe
bcoe approved these changes Dec 5, 2019
View reviewed changes
@bcoe

bcoe commented Dec 5, 2019

Copy link
Copy Markdown
Contributor

@coreyfarrell@guybedford this looks quite reasonable to me; @coreyfarrell when you have a moment, want to work on debugging the Travis tests? at which point I can kick off ci/cd?

@coreyfarrell

coreyfarrell commented Dec 5, 2019

Copy link
Copy Markdown
MemberAuthor

@bcoe the travis errors were unrelated and should be fixed by 781e41d, I've rebased to the current master.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@coreyfarrell

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
coreyfarrelland others added 2 commits December 5, 2019 19:39
@coreyfarrell
module: fix dynamic import from eval
da3f505
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.
Fixes: nodejs#30591
@guybedford@coreyfarrell
tweak importModuleDynamically inlining
bcc0331
@nodejs-github-bot

This comment has been minimized.

Sign in to view
bcoe
bcoe approved these changes Dec 6, 2019
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27413/

bcoe
bcoe approved these changes Dec 7, 2019
View reviewed changes

@bcoebcoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the most recent test run was successful, I am going to go ahead and land this.

bcoe pushed a commit that referenced this pull request Dec 7, 2019
@coreyfarrellBenjamin Coe
module: fix dynamic import from eval
4ec02d5
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.
Fixes: #30591
PR-URL: #30624
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@bcoe

bcoe commented Dec 7, 2019

Copy link
Copy Markdown
Contributor

Landed in 4ec02d5

@bcoebcoe closed this Dec 7, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@coreyfarrell@targos
module: fix dynamic import from eval
d4aa656
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.
Fixes: #30591
PR-URL: #30624
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 13, 2019
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
@coreyfarrell@MylesBorins
module: fix dynamic import from eval
a91b735
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.
Fixes: #30591
PR-URL: #30624
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@coreyfarrell@BethGriggs
module: fix dynamic import from eval
cad5c2b
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.
Fixes: #30591
PR-URL: #30624
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
@goto-bus-stopgoto-bus-stop mentioned this pull request Feb 18, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guybedfordguybedfordguybedford left review comments
+3 more reviewers
@bcoebcoebcoe approved these changes
@yorkieyorkieyorkie approved these changes
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

esmIssues and PRs related to the ECMAScript Modules implementation.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dynamic import not working on eval/print

7 participants

@coreyfarrell@nodejs-github-bot@bcoe@guybedford@yorkie@devsnek@MylesBorins