Skip to content

test: move test-worker-prof to sequential - #30628

Closed
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:worker-prof
Closed

test: move test-worker-prof to sequential#30628
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:worker-prof

Conversation

@Trott

@TrottTrott commented Nov 24, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Refs: #26401 (comment)

I'm definitely open to other ideas for fixing this, if we have any.

/ping @addaleax@gireeshpunathil

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26929/

@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26931/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26971/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26973/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26975/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26976/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26979/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26980/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26981/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26982/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26983/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26984/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26985/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26986/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26987/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26990/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26991/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26992/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26994/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26995/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26996/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27001/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27007/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27011/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27013/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27015/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2019•
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27017/ ✔️

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 26, 2019
@Trott

Trott commented Nov 26, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in ebb177e

Trott added a commit to Trott/io.js that referenced this pull request Nov 26, 2019
@Trott
test: move test-worker-prof to sequential
ebb177e
Refs: nodejs#26401 (comment)
PR-URL: nodejs#30628
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@TrottTrott closed this Nov 26, 2019
@Trott
Trott deleted the worker-prof branch November 26, 2019 18:17
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@Trott@addaleax
test: move test-worker-prof to sequential
949f2ad
Refs: #26401 (comment)
PR-URL: #30628
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@Trott@targos
test: move test-worker-prof to sequential
5fd943a
Refs: #26401 (comment)
PR-URL: #30628
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Trott@MylesBorins
test: move test-worker-prof to sequential
825b305
Refs: #26401 (comment)
PR-URL: #30628
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@joyeecheung@gireeshpunathil