fs: refactor rimraf retry options by cjihrig · Pull Request #30644 · nodejs/node

cjihrig · 2019-11-25T21:56:25Z

This PR implements the changes proposed in #30580.

This PR doesn't quite close out #30580 though because synchronous retries are not able to be fully implemented just yet (libuv/libuv#2548 should enable that soon though).

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

yorkie · 2019-11-25T22:09:48Z

How about supporting exponential backoff or allow to custom, which may react to the real world.

I don't plan on adding that myself, and definitely not in this PR. But someone could open a follow up PR that passes in a user defined function for that.

nodejs-github-bot · 2019-11-26T15:32:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27044/

nodejs-github-bot · 2019-11-26T18:46:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27054/

nodejs-github-bot · 2019-11-27T00:51:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27060/

nodejs-github-bot · 2019-11-27T14:34:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27073/

cjihrig · 2019-11-27T14:41:47Z

ping for reviews

nodejs-github-bot · 2019-11-27T15:33:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27078/

nodejs-github-bot · 2019-11-27T18:56:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27085/

nodejs-github-bot · 2019-11-27T22:34:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27100/

cjihrig · 2019-11-27T23:19:36Z

The failures were test-http2-client-upload, which is a known flake, and test-inspector-wait-for-connection, which is #30619. I'm going to land this.

This is part of reworking the rimraf retry logic. Refs: nodejs#30580 PR-URL: nodejs#30644 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit makes retries an opt-in feature by defaulting to no automatic retries. This will be particularly important once synchronous operations can sleep between attempts. Refs: nodejs#30580 PR-URL: nodejs#30644 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit removes the emfileWait option. EMFILE errors are now handled the same as any other retriable error. Refs: nodejs#30580 PR-URL: nodejs#30644 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit adds a retryDelay option to rimraf which configures the amount of time between retry operations. Refs: nodejs#30580 PR-URL: nodejs#30644 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

Co-authored-by: Thang Tran <trankimthang279@gmail.com> Fixes: nodejs#30482 Refs: nodejs#30499 Refs: nodejs#30580 PR-URL: nodejs#30644 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig · 2019-11-27T23:28:34Z

Landed in 84aa192...74f8196. Thanks for the reviews.

This is part of reworking the rimraf retry logic. Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit makes retries an opt-in feature by defaulting to no automatic retries. This will be particularly important once synchronous operations can sleep between attempts. Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit removes the emfileWait option. EMFILE errors are now handled the same as any other retriable error. Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit adds a retryDelay option to rimraf which configures the amount of time between retry operations. Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

Co-authored-by: Thang Tran <trankimthang279@gmail.com> Fixes: #30482 Refs: #30499 Refs: #30580 PR-URL: #30644 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: * fs: * Reworked experimental recursive `rmdir()` (cjihrig) #30644 * The `maxBusyTries` option is renamed to `maxRetries`, and its default is set to 0. The `emfileWait` option has been removed, and `EMFILE` errors use the same retry logic as other errors. The `retryDelay` option is now supported. `ENFILE` errors are now retried. * http: * Make maximum header size configurable per-stream or per-server (Anna Henningsen) #30570 * http2: * Make maximum tolerated rejected streams configurable (Denys Otrishko) #30534 * Allow to configure maximum tolerated invalid frames (Denys Otrishko) #30534 * wasi: * Introduce initial WASI support (cjihrig) #30258 PR-URL: #30774