Skip to content

doc: fix up N-API doc - #30656

Closed
NickNaso wants to merge 2 commits into
nodejs:masterfrom
NickNaso:fix-napi-doc
Closed

doc: fix up N-API doc#30656
NickNaso wants to merge 2 commits into
nodejs:masterfrom
NickNaso:fix-napi-doc

Conversation

@NickNaso

@NickNasoNickNaso commented Nov 26, 2019

Copy link
Copy Markdown
Member
  • Fixed the signature for napi_status napi_get_uv_event_loop from:
NAPI_EXTERNnapi_statusnapi_get_uv_event_loop(napi_envenv,
uv_loop_t**loop);

to:

NAPI_EXTERNnapi_statusnapi_get_uv_event_loop(napi_envenv,
uv_loop_s**loop);
  • In section Simple Asynchronous Operations changed type napi_work to napi_async_work
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Nov 26, 2019
@NickNaso

NickNaso commented Nov 27, 2019

Copy link
Copy Markdown
MemberAuthor

@mhdawson@gabrielf If you have time please review this PR.

mhdawson
mhdawson approved these changes Nov 27, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

legendecas
legendecas reviewed Nov 28, 2019
View reviewed changes
Comment threaddoc/api/n-api.md Outdated
@mhdawson

mhdawson commented Nov 28, 2019

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4091/

danbev pushed a commit that referenced this pull request Dec 4, 2019
@NickNaso@danbev
doc: fix up N-API doc
9ed67f4
PR-URL: #30656
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@danbev

danbev commented Dec 4, 2019

Copy link
Copy Markdown
Contributor

Landed in 9ed67f4.

@danbevdanbev closed this Dec 4, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@NickNaso@targos
doc: fix up N-API doc
543bf9d
PR-URL: #30656
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@NickNaso@targos
doc: fix up N-API doc
1c452f0
PR-URL: #30656
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@NickNaso@BethGriggs
doc: fix up N-API doc
005b601
PR-URL: #30656
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NickNaso@mhdawson@danbev@legendecas@nodejs-github-bot