Skip to content

Update release doc - #30673

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:update-release-doc
Closed

Update release doc#30673
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:update-release-doc

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Nov 26, 2019

Copy link
Copy Markdown
Contributor

Two different changes

  • Update algorithm in document to reflect the state of the script
  • Bold statement about how to re sign.

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 26, 2019
Comment threaddoc/releases.md Outdated
Updated doc to reflect what is now done in tools/release.sh
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2019
danbev pushed a commit that referenced this pull request Dec 2, 2019
Updated doc to reflect what is now done in tools/release.sh
PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@danbev

Copy link
Copy Markdown
Contributor

Landed in c5fc802.

@danbevdanbev closed this Dec 2, 2019
targos pushed a commit that referenced this pull request Dec 2, 2019
Updated doc to reflect what is now done in tools/release.sh
PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
targos pushed a commit that referenced this pull request Dec 5, 2019
Updated doc to reflect what is now done in tools/release.sh
PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Updated doc to reflect what is now done in tools/release.sh
PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
Updated doc to reflect what is now done in tools/release.sh
PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MylesBorins@danbev@rvagg@addaleax@nodejs-github-bot