Skip to content

doc: avoid proposal syntax in code example - #30685

Closed
alexzherdev wants to merge 1 commit into
nodejs:masterfrom
alexzherdev:patch-1
Closed

doc: avoid proposal syntax in code example#30685
alexzherdev wants to merge 1 commit into
nodejs:masterfrom
alexzherdev:patch-1

Conversation

@alexzherdev

@alexzherdevalexzherdev commented Nov 27, 2019

Copy link
Copy Markdown
Contributor
Checklist

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 27, 2019
@MylesBorinsMylesBorins added the esm Issues and PRs related to the ECMAScript Modules implementation. label Nov 28, 2019
MylesBorins
MylesBorins reviewed Nov 28, 2019
View reviewed changes
Comment threaddoc/api/esm.md Outdated
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2019
MylesBorins
MylesBorins approved these changes Nov 29, 2019
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@alexzherdev@addaleax
doc: avoid proposal syntax in code example
6233356
PR-URL: #30685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@addaleax

addaleax commented Nov 30, 2019

Copy link
Copy Markdown
Member

Landed in 6233356

@alexzherdev
alexzherdev deleted the patch-1 branch November 30, 2019 01:37
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@alexzherdev@addaleax
doc: avoid proposal syntax in code example
20dbce1
PR-URL: #30685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
@alexzherdev@MylesBorins
doc: avoid proposal syntax in code example
005cad3
PR-URL: #30685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@alexzherdev@BethGriggs
doc: avoid proposal syntax in code example
de3fdfa
PR-URL: #30685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
+1 more reviewer
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexzherdev@addaleax@MylesBorins@nodejs-github-bot