Skip to content

lib: enforce use of Boolean from primordials - #30698

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:primordials-boolean
Closed

lib: enforce use of Boolean from primordials#30698
targos wants to merge 1 commit into
nodejs:masterfrom
targos:primordials-boolean

Conversation

@targos

@targostargos commented Nov 28, 2019

Copy link
Copy Markdown
Member

Refs: #30697

@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 28, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27158/

@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27206/

targos added a commit that referenced this pull request Nov 30, 2019
@targos
lib: enforce use of Boolean from primordials
7fc5980
Refs: #30697
PR-URL: #30698
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos

targos commented Nov 30, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 7fc5980.

@targostargos closed this Nov 30, 2019
@targos
targos deleted the primordials-boolean branch November 30, 2019 12:39
targos added a commit that referenced this pull request Dec 1, 2019
@targos
lib: enforce use of Boolean from primordials
892bde6
Refs: #30697
PR-URL: #30698
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
targos added a commit that referenced this pull request Jan 14, 2020
@targos
lib: enforce use of Boolean from primordials
2e81795
Refs: #30697
PR-URL: #30698
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@targos@BethGriggs
lib: enforce use of Boolean from primordials
4151049
Refs: #30697
PR-URL: #30698
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@cjihrigcjihrigcjihrig approved these changes
@trivikrtrivikrtrivikr approved these changes
@ZYSzysZYSzysZYSzys approved these changes

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@benjamingr@cjihrig@trivikr@ZYSzys