Uh oh!
There was an error while loading. Please reload this page.
stream: improve write performance - #30736
Closed
ronag wants to merge 1 commit into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
ronagforce-pushed
the
stream-afterwrite3
branch
2 times, most recently
from
November 30, 2019 15:23
c1311ea to
601faebCompareMemberAuthor
ronagforce-pushed
the
stream-afterwrite3
branch
3 times, most recently
from
November 30, 2019 16:19
feab352 to
520388bCompareronag
commented
Nov 30, 2019
Uh oh!
There was an error while loading. Please reload this page.
ronagforce-pushed
the
stream-afterwrite3
branch
4 times, most recently
from
November 30, 2019 20:29
092225e to
5a99949Compare3 tasks
addaleax
commented
Dec 1, 2019
Member
@ronag Could you review this? I’ll review this as soon as I can :) |
ronagforce-pushed
the
stream-afterwrite3
branch
from
December 1, 2019 06:38
5a99949 to
251ce92Compareronag
commented
Dec 1, 2019
MemberAuthor
@addaleax rebased |
MemberAuthor
A bit more modest improvement after #30710 confidence improvement accuracy (*) (**) (***)
streams/writable-manywrites.js sync='no' n=2000000 0.10 % ±1.46% ±1.94% ±2.54%
streams/writable-manywrites.js sync='yes' n=2000000 *** 8.43 % ±1.73% ±2.30% ±3.00% |
ronagforce-pushed
the
stream-afterwrite3
branch
2 times, most recently
from
December 1, 2019 09:38
6d04fa4 to
63da91bComparelpinca
commented
Dec 1, 2019
Member
Added semver-major label due to e828f510. |
mcollina
commented
Dec 1, 2019
Member
Let's park this until #30733 is landed |
ronag
commented
Dec 14, 2019
MemberAuthor
This needs a blocked label |
ronagforce-pushed
the
stream-afterwrite3
branch
from
December 14, 2019 21:21
63da91b to
ee68b0dCompareronag
commented
Dec 14, 2019
MemberAuthor
This was referenced Sep 18, 2021
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is inspired by #30710.
Depends on #30733 (which is included).
Improves performance of
writeby avoidingprocess.nextTickand a number of conditions when possible in the hot path in sync mode.Details
``` confidence improvement accuracy (*) (**) (***) streams/writable-manywrites.js n=2000000 *** 1085.31 % ±19.19% ±25.86% ±34.31% ````EDIT: A bit more modest improvement after #30710
Note since #30733 is probably semver major, this should be the same.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes