Skip to content

lib: Replace Symbol global by the primordials Symbol - #30737

Closed
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:Symbol
Closed

lib: Replace Symbol global by the primordials Symbol#30737
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:Symbol

Conversation

@Sebastien-Ahkrin

@Sebastien-AhkrinSebastien-Ahkrin commented Nov 30, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Update some file to replace Symbol global object to the Symbol primordials.

And i just have created a line in "/lib/.eslintrc.yaml".

rules:
no-restricted-globals:
- name: Symbolmessage: "Use `const { Symbol } = primordials;` instead of the global."

Next, just adding : Symbol to every

const{// [...]
Symbol,}=primordials;

This task was given to me by @targos thanks ❤️
I hope this new PR will help you :x

@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 30, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27217/

@targos

targos commented Nov 30, 2019

Copy link
Copy Markdown
Member

Refs: #30697

@Sebastien-Ahkrin
Sebastien-Ahkrinforce-pushed the Symbol branch 2 times, most recently from d356582 to c58ec88CompareNovember 30, 2019 17:28
@Sebastien-Ahkrin
Sebastien-Ahkrinforce-pushed the Symbol branch 2 times, most recently from bbd0bf2 to c74a4f4CompareNovember 30, 2019 18:29
@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27235/

targos
targos requested changes Dec 2, 2019
View reviewed changes
Comment threadlib/internal/freeze_intrinsics.js Outdated
@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27330/

@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27366/

targos pushed a commit that referenced this pull request Dec 8, 2019
@Sebastien-Ahkrin@targos
lib: replace Symbol global by the primordials Symbol
eac3f0a
PR-URL: #30737
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos

targos commented Dec 8, 2019

Copy link
Copy Markdown
Member

Landed in eac3f0a

@targostargos closed this Dec 8, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@Sebastien-Ahkrin@targos
lib: replace Symbol global by the primordials Symbol
af01417
PR-URL: #30737
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin@targos
lib: replace Symbol global by the primordials Symbol
c6535c0
PR-URL: #30737
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin@BethGriggs
lib: replace Symbol global by the primordials Symbol
b95c50b
PR-URL: #30737
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
@nunoguedelhanunoguedelha mentioned this pull request Jun 9, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Sebastien-Ahkrin@nodejs-github-bot@targos@lpinca@cjihrig@BridgeAR@trivikr