dns: remove exports.ADNAME

[silverwind]

This is the semver-major part of #3051 which removes the nonexistant errorcode EADNAME.

[silverwind]

Fixed the commit title.

[ChALkeR]

From #3051 (comment), everything that actually uses or defines the misspelled variant ADNAME/EADNAME:

biojs-vis-blast-0.1.5.tgz/node/lib/dns.js:323:exports.ADNAME='EADNAME';cares-1.0.1.tgz/lib/cares.js:381:exports.ADNAME='EADNAME';commonjs-everywhere-0.9.7.tgz/node/lib/dns.js:203:exports.ADNAME='EADNAME';flush-all-0.1.1.tgz/node-v0.13/lib/dns.js:323:exports.ADNAME='EADNAME';jsg-0.0.3.tgz/testdata/node_core_modules/dns.js:258:exports.ADNAME='EADNAME';nice-http-0.1.0-alfa.tgz/src/dns.js:256:exports.ADNAME='EADNAME';node-core-lib-0.11.11.tgz/dns.js:258:exports.ADNAME='EADNAME';node-natives-0.10.25.tgz/dns.js:203:exports.ADNAME='EADNAME';pezhu-0.0.0.tgz/Downloads/node-v0.9.11/lib/dns.js:202:exports.ADNAME='EADNAME';pn-0.0.1.tgz/dns.js:7: ADNAME: {enumerable: true,value: dns.ADNAME},portable-js-0.0.3.tgz/misc/io/dns.js:338:exports.ADNAME='EADNAME';portable-js-0.0.3.tgz/misc/node/dns.js:325:exports.ADNAME='EADNAME';

Only the pn module actually uses it (I just filed an issue there), all the others copy-paste exports.ADNAME = 'EADNAME'.

LGTM for a major. There should be more explanation in the commit message details, though.

[silverwind]

Updated commit details and rebased.

[thefourtheye]

LGTM

[silverwind]

Thanks, landed in 680dda8.

[rvagg]

sorry to have missed this, I would have voted for adding a deprecation warning on a getter for this instead of jumping straight to removal

[rvagg]

actually, I'm pretty sure this was done over a weekend and merged way too fast, particularly for a semver-major, can we be a bit more patient on these kinds of things, pretty please?

[ChALkeR]

@rvagg It's a semver-major just to be on the safe side. It was never useful or documented -- it's a simple mistype. See #3051 (it also had the start of this discussion). I can hardly imagine how removing it could break (or even change) anything in real code.

If you still feel that there has to be a warning, it's not too late to introduce it. What do you think?

Just explaining things here, I got the point about semver-major PRs.

[rvagg]

OK .. so I'm a little slow on this one, just to confirm, this is simply an exported string and was not used or referenced by anything else right?

[silverwind]

@rvagg exactly. These error exports look to be there for comparision purpose so one can do if (err.code === dns.BADNAME). The first version of #3051 did both add the correct version and remove the incorrect one commit, but we then decided it's best to split the PR into two parts, one being major. It's highly unlikely anything is going to break in this change, imho.

[rvagg]

ok, thanks, I retract my comments then!