Skip to content

test: remove deprecated error logging - #3079

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:common-error
Closed

test: remove deprecated error logging#3079
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:common-error

Conversation

@Trott

@TrottTrott commented Sep 26, 2015

Copy link
Copy Markdown
Member

common.error() is just util.error() which is deprecated. Update instances to console.error().

@TrottTrott added the test Issues and PRs related to the tests. label Sep 26, 2015
@Trott

Trott commented Sep 27, 2015

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-commit/682/

@evanlucas

evanlucas commented Sep 28, 2015

Copy link
Copy Markdown
Contributor

Don't we try to not use logging in tests at all? So should we just remove these statements totally vs replacing?

@Trott

Trott commented Sep 28, 2015

Copy link
Copy Markdown
MemberAuthor

@evanlucas I know there are some folks who definitely think the tests should not have any console.error() statements. But I don't know if that viewpoint is consensus or not. Is it?

I thought about just removing them, but I was afraid it would be a slippery slope. If I remove all these statements, why not remove all the console.error() statements in every test? But then we're talking about a very large set of changes, and I definitely favor narrower change sets.

@Trott

Trott commented Oct 6, 2015

Copy link
Copy Markdown
MemberAuthor

Bump: This looks good or the statements should just be removed altogether?

@evanlucas

evanlucas commented Oct 6, 2015

Copy link
Copy Markdown
Contributor

I would vote for just removing them. Not sure if other agree though

@Trott

Trott commented Oct 6, 2015

Copy link
Copy Markdown
MemberAuthor

I started removing the calls to see if there were any issues. It helped find some dead code, actually. Sold. I removed them all and a few other nearby console logging calls. How's it look?

@TrottTrott changed the title test: update deprecated error loggingtest: remove deprecated error loggingOct 6, 2015
@Trott
test: remove deprecated error logging
80d5cd1
common.error() is just deprecated util.error() renamed.
Remove calls to it and some other extraneous console logging
in tests.
@bnoordhuis

bnoordhuis commented Oct 6, 2015

Copy link
Copy Markdown
Member

LGTM

@Trott

Trott commented Oct 7, 2015

Copy link
Copy Markdown
MemberAuthor

One last CI for good measure before landing: https://ci.nodejs.org/job/node-test-pull-request/444/

Trott added a commit that referenced this pull request Oct 7, 2015
@Trott
test: remove deprecated error logging
099cfbc
common.error() is just deprecated util.error() renamed.
Remove calls to it and some other extraneous console logging
in tests.
PR-URL: #3079
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott

Trott commented Oct 7, 2015

Copy link
Copy Markdown
MemberAuthor

Landed in 099cfbc.

@TrottTrott closed this Oct 7, 2015
@jasnelljasnell mentioned this pull request Oct 8, 2015
Closed
29 tasks
Trott added a commit that referenced this pull request Oct 8, 2015
@Trott@jasnell
test: remove deprecated error logging
e922716
common.error() is just deprecated util.error() renamed.
Remove calls to it and some other extraneous console logging
in tests.
PR-URL: #3079
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jasnelljasnell mentioned this pull request Oct 8, 2015
Closed
@Trott
Trott deleted the common-error branch January 13, 2022 22:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@evanlucas@bnoordhuis@jasnell