module: fixup lint regression by guybedford · Pull Request #30802 · nodejs/node

guybedford · 2019-12-05T05:12:22Z

The CI for #30336 was run before the linting change to ensure the use of primordials causing the commit at 1549c8e to fail.

This should resolve that issue.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

guybedford · 2019-12-05T05:12:34Z

It would be good to have this fast-tracked!

guybedford · 2019-12-05T05:44:17Z

CI is just about there on this one, apart from the flakes of course.

We still need another approval to merge though.

Trott · 2019-12-05T05:47:23Z

CI is just about there on this one, apart from the flakes of course.

Not seeing any flakes, but I'm seeing a Windows compilation failure that will prevent the Windows tests from running, so we'll definitely want to do a Resume Build once the rest of the CI finishes.

We still need another approval to merge though.

Yup. /ping @nodejs/modules-active-members

guybedford · 2019-12-05T05:48:15Z

@Trott that Windows failure has been coming up on every CI the past couple of days as far as I can tell.

Trott · 2019-12-05T05:50:06Z

@Trott that Windows failure has been coming up on every CI the past couple of days as far as I can tell.

Didn't show up in node-daily-master last night or the night before. We certainly should be landing no code changes whatsoever if Windows CI isn't running.

guybedford · 2019-12-05T05:57:49Z

I believe it is only the windows 2019 build that has been failing.

Trott · 2019-12-05T06:00:39Z

I believe it is only the windows 2019 build that has been failing.

If it fails, then the next job (that actually runs the tests!) doesn't run. 😱

Fortunately, it looks like it's been succeeding a lot more than failing: https://ci.nodejs.org/job/node-compile-windows-debug/

The last machine in the CI run (debian9-docker-armv7) is finishing up now so we should be able to try a Resume Build pretty quickly and see what happens.

guybedford · 2019-12-05T06:01:36Z

Yes it's really hard with this many flakes to tell what is a genuine failure. I believe I may have also missed the failure at https://ci.nodejs.org/job/node-test-binary-windows-js-suites/29/ on that merge... I'm looking into this now as well, to see if I can include the fix in this PR.

Trott · 2019-12-05T06:03:22Z

Yes it's really hard with this many flakes to tell what is a genuine failure.

Fair.

joaocgreis · 2019-12-05T06:22:56Z

Windows CI rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/32010/ - It looks like es-module/test-cjs-esm-warn is a real failure, but I just saw it failing on master as well so I don't know if it's related to this PR.

There were a lot of failures compiling in Windows today, I took a few machines offline and I believe it's mitigated for now. I haven't figured out what's happening yet, but it looks like a missing build dependency.

guybedford · 2019-12-05T06:23:43Z

I'm on the Windows rebuilds here too, no worries! Will cancel and run again due to a lint issue.

guybedford · 2019-12-05T06:25:53Z

(the two latest commits should fix the Windows regression that slipped through into master as well, as mentioned in #30802 (comment))

joaocgreis

test-cjs-esm-warn fix LGTM

Trott · 2019-12-05T06:33:19Z

@nodejs/collaborators This could use a second review an 👍 to fast-tracking so we can unbreak CI. PTAL if you're around right now?

Trott · 2019-12-05T06:34:06Z

@nodejs/collaborators This could use a second review an 👍 to fast-tracking so we can unbreak CI. PTAL if you're around right now?

Whoops, never mind, I'm three minutes out of date, this has all the needed approvals and can land once we get a green/yellow CI.

guybedford · 2019-12-05T06:39:06Z

I tried to retrigger the build on the last suggestion, but can't tell if it's running against the right commit?

Will stop pushing buttons now to avoid further interference, but hopefully we nearly there now.

guybedford · 2019-12-05T06:39:58Z

Ok, CI run seems like it's doing the right thing. Will keep an eye on it here.

guybedford · 2019-12-05T07:01:27Z

Hit another windows failure on the other PR that landed today... that seems itself to be a new flake...!

Is there a way we can just run the Windows CI build?

nodejs-github-bot · 2019-12-05T07:09:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27348/

joaocgreis · 2019-12-05T07:10:08Z

@guybedford you can go to https://ci.nodejs.org/job/node-test-commit-windows-fanned/ and click "Build with Parameters".

mcollina

lgtm, +1 to fast-track

guybedford · 2019-12-05T07:40:56Z

Seems there was a Windows issue brought in on #30678 which the timeout was possibly masking. We should either revert that PR or add a fix. I'm running a local windows build now, but don't have much more time here right now.

Trott · 2019-12-05T07:43:50Z

Seems there was a Windows issue brought in on #30678 which the timeout was possibly masking. We should either revert that PR or add a fix. I'm running a local windows build now, but don't have much more time here right now.

We have a successful Windows CI on the most recent version of this PR so I'd be inclined to land and address this other issue subsequently if it recurs. Just waiting for the docker build to start and finish at this point....

guybedford · 2019-12-05T07:44:15Z

These GitHub summaries being out of sync always fool me. Yes it seems we are good.

guybedford · 2019-12-05T07:49:42Z

Landed in 781e41d.

PR-URL: #30802 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

module: fixup lint regression
6fc1b9b

guybedford added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 5, 2019

This comment has been minimized.
Sign in to view

Trott approved these changes Dec 5, 2019
View reviewed changes

fixup windows bug attempt
17f0235

fixup quotes
7e916c6

joaocgreis approved these changes Dec 5, 2019
View reviewed changes

Trott reviewed Dec 5, 2019
View reviewed changes

Comment threadtest/es-module/test-cjs-esm-warn.js Outdated

fixup regex global
1bb808f

further test refinements
b005b92

This comment has been minimized.
Sign in to view

remove unnecessary line
45a835c

This comment has been minimized.
Sign in to view

try increase timeout
3698b28

Trott reviewed Dec 5, 2019
View reviewed changes

Comment threadtest/es-module/test-esm-specifiers-both-flags.mjs Outdated

remove timeout
3903f5a

mcollina approved these changes Dec 5, 2019
View reviewed changes

Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. labels Dec 5, 2019

Trott added the esm Issues and PRs related to the ECMAScript Modules implementation. label Dec 5, 2019

guybedford closed this Dec 5, 2019

guybedford added a commit that referenced this pull request Dec 5, 2019
module: fixup lint and test regressions
781e41d
PR-URL: #30802 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos pushed a commit that referenced this pull request Dec 9, 2019
module: fixup lint and test regressions
a7ec78f
PR-URL: #30802 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

MylesBorins mentioned this pull request Dec 13, 2019
v13.4.0 proposal #30937
Merged

MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
module: fixup lint and test regressions
2a2ae8e
PR-URL: #30802 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed

BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
module: fixup lint and test regressions
77c69f5
PR-URL: #30802 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged

Uh oh!

Uh oh!

Conversation

guybedford commented Dec 5, 2019

Checklist

Uh oh!

guybedford commented Dec 5, 2019

Uh oh!

This comment has been minimized.

guybedford commented Dec 5, 2019

Uh oh!

Trott commented Dec 5, 2019

Uh oh!

guybedford commented Dec 5, 2019

Uh oh!

Trott commented Dec 5, 2019

Uh oh!

guybedford commented Dec 5, 2019

Uh oh!

Trott commented Dec 5, 2019

Uh oh!

guybedford commented Dec 5, 2019

Uh oh!

Trott commented Dec 5, 2019

Uh oh!

joaocgreis commented Dec 5, 2019

Uh oh!

guybedford commented Dec 5, 2019

Uh oh!

guybedford commented Dec 5, 2019

Uh oh!

joaocgreis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Trott commented Dec 5, 2019

Uh oh!

Trott commented Dec 5, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

guybedford commented Dec 5, 2019

Uh oh!

guybedford commented Dec 5, 2019

Uh oh!

guybedford commented Dec 5, 2019

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 5, 2019

Uh oh!

joaocgreis commented Dec 5, 2019

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

guybedford commented Dec 5, 2019

Uh oh!

Trott commented Dec 5, 2019

Uh oh!

guybedford commented Dec 5, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guybedford commented Dec 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guybedford commented Dec 5, 2019•
edited
Loading