doc: remove outdated try/catch statements and use const by JungMinu · Pull Request #3087 · nodejs/node

JungMinu · 2015-09-27T08:20:47Z

The code shows that it throws on a lack of entropy, but the note below says that it does not.
Remove outdated try/catchstatements in sync examples about crypto.randomBytes to make it clear

fix description about crypto.randomBytes

bnoordhuis · 2015-09-27T08:29:45Z

I don't think that's very enlightening for people not familiar with openssl or the code base. I don't really have suggestions on how to reword it, just that it's not very helpful now (and the part about CheckEntropy() is arguably wrong in a nuanced way.)
Also, please wrap lines at 80 columns.

Perhaps, @JungMinu, you could update the code block instead? The note is mostly correct about the current behavior. Maybe remove the try / catch block in the example?

bnoordhuis · 2015-09-27T08:32:32Z

The commit log could be be a little more descriptive. Ideally, you shouldn't have to look at the diff to know what a commit changed.

JungMinu · 2015-09-27T08:34:47Z

@bnoordhuis Thanks, I will update

JungMinu · 2015-09-27T08:40:39Z

@brendanashworth Thanks for your comment, I would love to 😄

brendanashworth · 2015-09-27T08:46:39Z

@JungMinu assuming you've setup locally with git, you can always add new changes as new commits and push them to github. It will automatically update this PR, which is easier for everyone.

JungMinu · 2015-09-27T08:53:08Z

@brendanashworth Yes, I will.

remove outdated examples about crypto.randomBytes to make it clear

JungMinu · 2015-09-27T09:00:58Z

@brendanashworth Based on your comments, I removed try / catch block.

JungMinu · 2015-09-27T10:30:13Z

@brendanashworth @bnoordhuis Please review

bnoordhuis · 2015-09-27T11:24:26Z

I speculate that @brendanashworth's suggestion was to remove the try/catch statement, not the call to crypto.randomBytes().

fix outdated examples about crypto.randomBytes to make it clear

JungMinu · 2015-09-27T11:51:14Z

@bnoordhuis Thanks, I've updated

The code shows that it throws on a lack of entropy, but the note below says that it does not. Remove outdated `try/catch`statements in sync examples about crypto.randomBytes to make it clear

JungMinu · 2015-09-27T15:25:07Z

@bnoordhuis I've updated commit log and description, Thanks 😄

The code shows that it throws on a lack of entropy, but the note below says that it does not. Remove outdated try/catchstatements in sync examples about crypto.randomBytes to make it clear

The code shows that it throws on a lack of entropy, but the note below says that it does not. Remove outdated `try/catch`statements in sync examples about crypto.randomBytes to make it clear

Fishrock123 · 2015-09-27T17:45:27Z

Does this mean there should be a try/catch? randomBytes() will never throw anymore, right?

The code shows that it throws on a lack of entropy, but the note below says that it does not. Remove outdated `try/catch`statements in sync examples about crypto.randomBytes to make it clear

JungMinu · 2015-09-27T18:51:05Z

@Fishrock123 Sorry, I made a mistake.
I've updated.

JungMinu · 2015-09-27T18:51:42Z

@Fishrock123 Thanks for your comment 😄

bnoordhuis · 2015-09-28T09:31:00Z

LGTM

brendanashworth · 2015-09-28T23:16:02Z

Perfect, also LGTM!

thefourtheye · 2015-09-29T04:30:31Z

May I suggest to use const?

thefourtheye · 2015-09-29T04:30:58Z

LGTM with take-it or leave-it suggestion

The code shows that it throws on a lack of entropy, but the note below says that it does not. Remove outdated try/catchstatements in sync examples about crypto.randomBytes to make it clear. In addition, use `const` instead of `var` for constant variable.

JungMinu · 2015-09-29T04:37:05Z

@thefourtheye Thanks, I've updated

Fixes description about crypto.randomBytes. Fixes: #3081 PR-URL: #3087 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

brendanashworth · 2015-10-01T03:28:55Z

Landed in d32363f, thanks @JungMinu!

Fixes description about crypto.randomBytes. Fixes: #3081 PR-URL: #3087 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

doc: fix crypto.randomBytes
54cd451
fix description about crypto.randomBytes

JungMinu mentioned this pull request Sep 27, 2015
crypto.randomBytes documentation needs improvement #3081
Closed

bnoordhuis reviewed Sep 27, 2015
View reviewed changes

brendanashworth added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Sep 27, 2015

doc: update examples about crypto.randomBytes
0d0154d
remove outdated examples about crypto.randomBytes to make it clear

doc: update examples about crypto.randomBytes
a8af4f3
fix outdated examples about crypto.randomBytes to make it clear

JungMinu changed the title ~~doc: fix crypto.randomBytes~~doc: Remove outdated try/catchstatements in sync examplesSep 27, 2015

JungMinu changed the title ~~doc: Remove outdated try/catchstatements in sync examples~~doc: Remove outdated try/catch statements in sync examplesSep 27, 2015

JungMinu changed the title ~~doc: Remove outdated try/catch statements in sync examples~~doc: Remove outdated try/catch statements in syncSep 27, 2015

doc: remove outdated try/catchstatements in sync
69b5fb9
The code shows that it throws on a lack of entropy, but the note below says that it does not. Remove outdated `try/catch`statements in sync examples about crypto.randomBytes to make it clear

JungMinu added 2 commits September 28, 2015 00:31

doc: remove outdated 'try/catch' statement in sync
77047dd
The code shows that it throws on a lack of entropy, but the note below says that it does not. Remove outdated try/catchstatements in sync examples about crypto.randomBytes to make it clear

doc: remove outdated 'try/catch' statement in sync
c723c46
The code shows that it throws on a lack of entropy, but the note below says that it does not. Remove outdated `try/catch`statements in sync examples about crypto.randomBytes to make it clear

Fishrock123 reviewed Sep 27, 2015
View reviewed changes

doc: remove outdated 'try/catch' statement in sync
879fa25
The code shows that it throws on a lack of entropy, but the note below says that it does not. Remove outdated `try/catch`statements in sync examples about crypto.randomBytes to make it clear

thefourtheye reviewed Sep 29, 2015
View reviewed changes

Comment threaddoc/api/crypto.markdown Outdated
thefourtheyeSep 29, 2015
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I suggest to use const?

JungMinu changed the title ~~doc: Remove outdated try/catch statements in sync~~doc: remove outdated try/catch statements and use constSep 29, 2015

brendanashworth closed this Oct 1, 2015

rvagg mentioned this pull request Oct 3, 2015
Release proposal: v4.1.2 #3128
Closed

aliscco mentioned this pull request Jun 22, 2023
[Snyk] Security upgrade karma from 1.3.0 to 3.0.0 aliscco/alisco-node#496
Open

Uh oh!

Uh oh!

Conversation

JungMinu commented Sep 27, 2015

Uh oh!

bnoordhuisSep 27, 2015

Choose a reason for hiding this comment

Uh oh!

brendanashworthSep 27, 2015

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Sep 27, 2015

Uh oh!

JungMinu commented Sep 27, 2015

Uh oh!

JungMinu commented Sep 27, 2015

Uh oh!

brendanashworth commented Sep 27, 2015

Uh oh!

JungMinu commented Sep 27, 2015

Uh oh!

JungMinu commented Sep 27, 2015

Uh oh!

JungMinu commented Sep 27, 2015

Uh oh!

bnoordhuis commented Sep 27, 2015

Uh oh!

JungMinu commented Sep 27, 2015

Uh oh!

JungMinu commented Sep 27, 2015

Uh oh!

Fishrock123Sep 27, 2015

Choose a reason for hiding this comment

Uh oh!

JungMinu commented Sep 27, 2015

Uh oh!

JungMinu commented Sep 27, 2015

Uh oh!

bnoordhuis commented Sep 28, 2015

Uh oh!

brendanashworth commented Sep 28, 2015

Uh oh!

thefourtheyeSep 29, 2015

Choose a reason for hiding this comment

Uh oh!

thefourtheye commented Sep 29, 2015

Uh oh!

JungMinu commented Sep 29, 2015

Uh oh!

brendanashworth commented Oct 1, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants