Uh oh!
There was an error while loading. Please reload this page.
sys: Mark as deprecated - #309
Closed
geek wants to merge 4 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Small nit, but could you change this to:
sys is deprecated. Use util instead. (Ref: #166 (comment))
cjihrig
commented
Jan 12, 2015
Contributor
Other than one small comment, LGTM |
cjihrig
commented
Jan 12, 2015
Contributor
This falls into the same category as the |
cjihrig
commented
Jan 12, 2015
Contributor
@geek this fails
|
geek
commented
Jan 12, 2015
MemberAuthor
@cjihrig fixed |
rvagg
commented
Jan 12, 2015
Member
I think this should land for 1.0.0, it was discussed and agreed at a TC meeting and was just waiting for the code. So lgtm. |
rvagg
commented
Jan 12, 2015
Member
@geek please squash the commits into the original one and we should be able to land this I think |
geek
commented
Jan 13, 2015
MemberAuthor
Closing in favor of #317 |
geek
commented
Jan 13, 2015
MemberAuthor
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #182