Uh oh!
There was an error while loading. Please reload this page.
test: add test for validation for wasi.start() argument - #30919
Merged
Conversation
lpinca
approved these changes
Dec 12, 2019
cjihrig
approved these changes
Dec 12, 2019
nodejs-github-bot
commented
Dec 12, 2019
Collaborator
addaleax
approved these changes
Dec 12, 2019
gengjiawen
approved these changes
Dec 13, 2019
Trottforce-pushed
the
wasi-start-validation
branch
from
December 14, 2019 21:35
eaab76d to
decc5f5CompareTrott
commented
Dec 14, 2019
MemberAuthor
Landed in decc5f5 |
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30919 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30919 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30919 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve test coverage in lib/wasi.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes