Skip to content

benchmark: use let/const instead of var in buffers - #30945

Closed
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:benchmarks_buffers
Closed

benchmark: use let/const instead of var in buffers#30945
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:benchmarks_buffers

Conversation

@dnlup

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. labels Dec 13, 2019
@BridgeAR

Copy link
Copy Markdown
Member

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2019
@targos

Copy link
Copy Markdown
Member

Landed in bfce726

@targostargos closed this Dec 16, 2019
targos pushed a commit that referenced this pull request Dec 16, 2019
PR-URL: #30945
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30945
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 17, 2019
@dnlup
dnlup deleted the benchmarks_buffers branch January 10, 2020 13:39
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30945
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request Jan 15, 2020
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30945
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.bufferIssues and PRs related to the buffer subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@dnlup@BridgeAR@targos@trivikr@nodejs-github-bot