Skip to content

lib: replace Symbol.hasInstance by SymbolHasInstance - #30948

Closed
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:SymbolHasInstance
Closed

lib: replace Symbol.hasInstance by SymbolHasInstance#30948
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:SymbolHasInstance

Conversation

@Sebastien-Ahkrin

@Sebastien-AhkrinSebastien-Ahkrin commented Dec 13, 2019

Copy link
Copy Markdown
Contributor

Just replaced every Symbol.hasInstance by SymbolHasInstance in the lib/* folder
For this, i just have added SymbolHasInstance in the import

const{
SymbolHasInstance,}=primordials;

Of course i have removed unused import of Symbol 😄
I hope this pull request will help you ! :P

@nodejs-github-botnodejs-github-bot added console Issues and PRs related to the console subsystem. stream Issues and PRs related to the stream subsystem. labels Dec 13, 2019
@Sebastien-Ahkrin

Sebastien-Ahkrin commented Dec 13, 2019

Copy link
Copy Markdown
ContributorAuthor

Refs: #30697

mcollina
mcollina approved these changes Dec 14, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2019
@nodejs-github-bot

nodejs-github-bot commented Dec 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27712/

@nodejs-github-bot

nodejs-github-bot commented Dec 16, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27726/

targos pushed a commit that referenced this pull request Dec 16, 2019
@Sebastien-Ahkrin@targos
lib: replace Symbol.hasInstance by SymbolHasInstance
48d986c
PR-URL: #30948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos

targos commented Dec 16, 2019

Copy link
Copy Markdown
Member

Landed in 48d986c

@targostargos closed this Dec 16, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Sebastien-Ahkrin@MylesBorins
lib: replace Symbol.hasInstance by SymbolHasInstance
f51b5bd
PR-URL: #30948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 17, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin@targos
lib: replace Symbol.hasInstance by SymbolHasInstance
581e837
PR-URL: #30948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin@BethGriggs
lib: replace Symbol.hasInstance by SymbolHasInstance
e01433d
PR-URL: #30948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.consoleIssues and PRs related to the console subsystem.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Sebastien-Ahkrin@nodejs-github-bot@targos@mcollina@jasnell@Trott@cjihrig@devnexen@BridgeAR@trivikr