Uh oh!
There was an error while loading. Please reload this page.
smalloc: remove module - #3099
Closed
brendanashworth wants to merge 1 commit into
Closed
Conversation
Bye bye, smalloc. I'm not sure why this was still here; it was removed a little while ago and hasn't worked since. It wasn't packaged in the binary, either.
targos
commented
Sep 28, 2015
Member
LGTM if the tests pass. |
thefourtheye
commented
Sep 28, 2015
Contributor
Exactly the same as targos's comment |
brendanashworth
commented
Sep 28, 2015
ContributorAuthor
Thanks. CI: https://ci.nodejs.org/job/node-test-commit/687/ |
ChALkeR
commented
Sep 28, 2015
Member
LGTM. For reference, Copy-paste from node.js/io.js: biojs-vis-blast-0.1.5.tgz/node/lib/fs.js:43:varkMaxLength=require('smalloc').kMaxLength;biojs-vis-blast-0.1.5.tgz/node/test/simple/test-buffer.js:27:varsmalloc=require('smalloc');biojs-vis-blast-0.1.5.tgz/node/test/simple/test-smalloc.js:27:varsmalloc=require('smalloc');flush-all-0.1.1.tgz/node-v0.13/lib/fs.js:43:varkMaxLength=require('smalloc').kMaxLength;flush-all-0.1.1.tgz/node-v0.13/test/simple/test-buffer.js:27:varsmalloc=require('smalloc');flush-all-0.1.1.tgz/node-v0.13/test/simple/test-smalloc.js:27:varsmalloc=require('smalloc');jsg-0.0.3.tgz/testdata/node_core_modules/fs.js:41:varkMaxLength=require('smalloc').kMaxLength;mock-fs-3.2.0.tgz/node/fs-0.11.13.js:41:varkMaxLength=require('smalloc').kMaxLength;mock-fs-3.2.0.tgz/node/fs-0.12.0.js:43:varkMaxLength=require('smalloc').kMaxLength;mock-fs-3.2.0.tgz/node/fs-1.1.0.js:20:constkMaxLength=require('smalloc').kMaxLength;mock-fs-3.2.0.tgz/node/fs-2.0.0.js:20:constkMaxLength=require('smalloc').kMaxLength;nae-fs-0.0.2.tgz/_source/fs.js:42:varkMaxLength=require('smalloc').kMaxLength;node-core-lib-0.11.11.tgz/fs.js:41:varkMaxLength=require('smalloc').kMaxLength;node-core-test-simple-0.11.11.tgz/test-smalloc.js:26:varsmalloc=require('smalloc');portable-js-0.0.3.tgz/misc/node/fs.js:45:varkMaxLength=require('smalloc').kMaxLength;Other usage: nodeinjection-0.0.5.tgz/src/CoreModules.js:26: registry.register('smalloc',[],function(){returnrequire('smalloc');});reblaze-0.2.1.tgz/bench/matrix.js:1:varsmalloc=require('smalloc'); |
bnoordhuis
commented
Sep 28, 2015
Member
LGTM. I forgot to remove it in 70d1f32 although I did remove lib/internal/smalloc.js. |
Fishrock123
commented
Sep 28, 2015
Contributor
This will currently throw an error anyways, right? That would mean this can land in 4.x? |
ChALkeR
commented
Sep 28, 2015
Member
@Fishrock123 Yes. |
brendanashworth
commented
Sep 28, 2015
ContributorAuthor
@Fishrock123 no harm - not sure if there'd be a benefit of back porting it, though - it just clears confusion on edit: ci is happy, merging |
brendanashworth added a commit
that referenced
this pull request
Sep 28, 2015
Bye bye, smalloc. I'm not sure why this was still here; it was removed in 70d1f32 and hasn't worked since. It wasn't packaged in the binary, either. Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #3099
brendanashworth
commented
Sep 28, 2015
ContributorAuthor
Landed in 20dae2a, thank you reviewers! |
brendanashworth added a commit
that referenced
this pull request
Sep 30, 2015
Bye bye, smalloc. I'm not sure why this was still here; it was removed in 70d1f32 and hasn't worked since. It wasn't packaged in the binary, either. Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #3099
This was referenced Sep 30, 2015
brendanashworth added a commit
that referenced
this pull request
Sep 30, 2015
Bye bye, smalloc. I'm not sure why this was still here; it was removed in 70d1f32 and hasn't worked since. It wasn't packaged in the binary, either. Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #3099
MylesBorins
commented
Nov 17, 2015
Contributor
landed in v4.x-staging in 37cdeaf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bye bye, smalloc. I'm not sure why this was still here; it was removed
a little while ago and hasn't worked since. It wasn't packaged in the
binary, either.