Skip to content

esm: empty ext from pkg type/main doesnt affect format - #31021

Closed
bmeck wants to merge 1 commit into
nodejs:masterfrom
bmeck:constrain-main-format-defaulting
Closed

esm: empty ext from pkg type/main doesnt affect format#31021
bmeck wants to merge 1 commit into
nodejs:masterfrom
bmeck:constrain-main-format-defaulting

Conversation

@bmeck

@bmeckbmeck commented Dec 18, 2019

Copy link
Copy Markdown
Member

BREAKING (kind of a bugfix? unclear)

This ensures files with unknown extensions like extension.unknown are not
loaded as CJS/ESM when imported as a main entry point and makes
sure that those files would maintain the same format even if loaded
after the main entrypoint.

Added tests for importing missing extension and unknown extension after entrypoint along the way.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@bfarias-godaddy
esm: empty ext from pkg type/main doesnt affect format
05e8b8e
This ensures files with unknown extensions like foo.bar are not
loaded as CJS/ESM when imported as a main entry point and makes
sure that those files would maintain the same format even if loaded
after the main entrypoint.
@bmeckbmeck added the esm Issues and PRs related to the ECMAScript Modules implementation. label Dec 18, 2019
@bmeck

bmeck commented Dec 18, 2019

Copy link
Copy Markdown
MemberAuthor

CC: @nodejs/modules-active-members

guybedford
guybedford requested changes Dec 18, 2019
View reviewed changes

@guybedfordguybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the major features of the ES module resolver is being able to support new file extensions in future, which is reliant on the fact that we always throw for unknown file extensions.

Giving special treatment to isMain was how we did this while ensuring compatibility with existing bins.

Happy to flesh this out further, but I don't think we should lose that extension property for the ESM resolver.

Comment threaddoc/api/esm.md
@bmeck

bmeck commented Dec 19, 2019

Copy link
Copy Markdown
MemberAuthor

It seems like there might be something more that needs to be done for node ./entry-point.wasm to handle WASI in addition to the changes here. Asking around about how main() and import are setup for WASI and it seems that entry points have some special behavior. We should ensure that is handled but likely would be a follow on PR instead of on top this one.

@bmeckbmeck mentioned this pull request Dec 19, 2019
Open
@nodejs-github-bot

nodejs-github-bot commented Dec 24, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27914/

@guybedford

guybedford commented Dec 29, 2019

Copy link
Copy Markdown
Contributor

It seems like there might be something more that needs to be done for node ./entry-point.wasm to handle WASI in addition to the changes here. Asking around about how main() and import are setup for WASI and it seems that entry points have some special behavior. We should ensure that is handled but likely would be a follow on PR instead of on top this one.

We are likely still missing the proper work on how Web Assembly integrates into the module system. There might be Web Assembly headers in future that specify the top-level resolution (like package.json). There is also some work to allow Web Assembly start functions to themselves run instantiation (removing the need for JS to be primary entry). Node.js should definitely track whatever happens here as it stabilizes.

@nodejs-github-bot

nodejs-github-bot commented Dec 29, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28018/

bmeck pushed a commit that referenced this pull request Dec 31, 2019
@bfarias-godaddy
esm: empty ext from pkg type/main doesnt affect format
baa3621
This ensures files with unknown extensions like foo.bar are not
loaded as CJS/ESM when imported as a main entry point and makes
sure that those files would maintain the same format even if loaded
after the main entrypoint.
PR-URL: #31021
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@bmeck

bmeck commented Dec 31, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in baa3621

@bmeckbmeck closed this Dec 31, 2019
@bmeckbmeck mentioned this pull request Jan 2, 2020
Closed
2 tasks
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@bfarias-godaddy@BridgeAR
esm: empty ext from pkg type/main doesnt affect format
24a0212
This ensures files with unknown extensions like foo.bar are not
loaded as CJS/ESM when imported as a main entry point and makes
sure that those files would maintain the same format even if loaded
after the main entrypoint.
PR-URL: #31021
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@BridgeARBridgeAR mentioned this pull request Jan 7, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
@bfarias-godaddy@MylesBorins
esm: empty ext from pkg type/main doesnt affect format
b95bb38
This ensures files with unknown extensions like foo.bar are not
loaded as CJS/ESM when imported as a main entry point and makes
sure that those files would maintain the same format even if loaded
after the main entrypoint.
PR-URL: #31021
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@targostargos mentioned this pull request Jan 15, 2020
Closed
GeoffreyBooth added a commit to GeoffreyBooth/node that referenced this pull request Jan 19, 2020
@GeoffreyBooth
module: revertnodejs#31021
efdc861
reverses baa3621
@GeoffreyBoothGeoffreyBooth mentioned this pull request Jan 19, 2020
Closed
GeoffreyBooth added a commit to GeoffreyBooth/node that referenced this pull request Jan 20, 2020
@GeoffreyBooth
module: revertnodejs#31021
5752a6f
reverses baa3621
@GeoffreyBoothGeoffreyBooth mentioned this pull request Jan 20, 2020
Closed
4 tasks
GeoffreyBooth added a commit that referenced this pull request Jan 23, 2020
@GeoffreyBooth
module: revert#31021
04d07ed
reverses baa3621
PR-URL: #31415
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@bfarias-godaddy@BethGriggs
esm: empty ext from pkg type/main doesnt affect format
298fdbe
This ensures files with unknown extensions like foo.bar are not
loaded as CJS/ESM when imported as a main entry point and makes
sure that those files would maintain the same format even if loaded
after the main entrypoint.
PR-URL: #31021
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@GeoffreyBooth@codebytere
module: revert#31021
6797656
reverses baa3621
PR-URL: #31415
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
Merged
@guybedfordguybedford mentioned this pull request Mar 17, 2020
Closed
@aduh95aduh95 mentioned this pull request Sep 8, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guybedfordguybedfordguybedford approved these changes
@hybristhybristAwaiting requested review from hybrist

Assignees

No one assigned

Labels

esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bmeck@nodejs-github-bot@guybedford@bfarias-godaddy