Uh oh!
There was an error while loading. Please reload this page.
zlib: allow writes after readable 'end' to finish - #31082
Closed
addaleax wants to merge 3 commits into
Closed
Conversation
Call the callback for writes that occur after the stream is closed.
This also requires changes to the code to not call `.destroy()`
on the stream in `.on('end')`, and to ignore chunks written
afterwards.
Previously, these writes would just queue up silently, as their
`_write()` callback would never have been called.
Fixes: nodejs#30976lundibundi
approved these changes
Dec 24, 2019
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
nodejs-github-bot
commented
Dec 24, 2019
Collaborator
lpinca
approved these changes
Dec 25, 2019
lpinca
commented
Dec 25, 2019
Member
Thank you Anna. |
bnoordhuis
approved these changes
Dec 25, 2019
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>
nodejs-github-bot
commented
Dec 25, 2019
Collaborator
Trott
approved these changes
Dec 26, 2019
jasnell
approved these changes
Dec 26, 2019
cjihrig
approved these changes
Dec 26, 2019
nodejs-github-bot
commented
Dec 26, 2019
Collaborator
addaleax
commented
Dec 27, 2019
MemberAuthor
Landed in 0e89b64 |
addaleax added a commit
that referenced
this pull request
Dec 27, 2019
Call the callback for writes that occur after the stream is closed.
This also requires changes to the code to not call `.destroy()`
on the stream in `.on('end')`, and to ignore chunks written
afterwards.
Previously, these writes would just queue up silently, as their
`_write()` callback would never have been called.
Fixes: #30976
PR-URL: #31082
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>lpinca
commented
Dec 27, 2019
Member
I think this should not land on v10.x unless 28db96f is also backported. Please correct me if I am wrong. |
addaleax
commented
Dec 27, 2019
MemberAuthor
BridgeAR pushed a commit
that referenced
this pull request
Jan 3, 2020
Call the callback for writes that occur after the stream is closed.
This also requires changes to the code to not call `.destroy()`
on the stream in `.on('end')`, and to ignore chunks written
afterwards.
Previously, these writes would just queue up silently, as their
`_write()` callback would never have been called.
Fixes: #30976
PR-URL: #31082
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>4 tasks
Merged
targos pushed a commit
that referenced
this pull request
Jan 14, 2020
Call the callback for writes that occur after the stream is closed.
This also requires changes to the code to not call `.destroy()`
on the stream in `.on('end')`, and to ignore chunks written
afterwards.
Previously, these writes would just queue up silently, as their
`_write()` callback would never have been called.
Fixes: #30976
PR-URL: #31082
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>BethGriggs pushed a commit
that referenced
this pull request
Feb 6, 2020
Call the callback for writes that occur after the stream is closed.
This also requires changes to the code to not call `.destroy()`
on the stream in `.on('end')`, and to ignore chunks written
afterwards.
Previously, these writes would just queue up silently, as their
`_write()` callback would never have been called.
Fixes: #30976
PR-URL: #31082
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Merged
3 tasks
stefanpenner
commented
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call the callback for writes that occur after the stream is closed.
This also requires changes to the code to not call
.destroy()on the stream in
.on('end'), and to ignore chunks writtenafterwards.
Previously, these writes would just queue up silently, as their
_write()callback would never have been called./cc @lpinca
Fixes: #30976
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes