Uh oh!
There was an error while loading. Please reload this page.
deps: V8: cherry-pick a4545db74e52 - #31127
Closed
devnexen wants to merge 1 commit into
Closed
Conversation
cjihrig
commented
Dec 29, 2019
Contributor
Should this bump |
devnexenforce-pushed
the
v8-cherrypick-freebsd2
branch
from
December 29, 2019 14:54
c681420 to
8c14146Comparetargos
commented
Dec 29, 2019
Member
Could you use the |
devnexenforce-pushed
the
v8-cherrypick-freebsd2
branch
from
December 29, 2019 15:31
8c14146 to
d4d8ab7Comparegengjiawen
requested changes
Dec 29, 2019
gengjiawen
left a comment
Member
There was a problem hiding this comment.
Looks like related v8 file is missing.
Original commit message: FreeBSD update of process library mapping listing. Not best to rely on /proc presence basically when the linux compatibily layer is enabled so going through more programmatically. Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65442} Refs: v8/v8@a4545db
devnexenforce-pushed
the
v8-cherrypick-freebsd2
branch
from
December 29, 2019 15:43
d4d8ab7 to
232ee8bComparegengjiawen
approved these changes
Dec 29, 2019
Collaborator
BridgeAR
approved these changes
Jan 2, 2020
BridgeAR
commented
Jan 2, 2020
Member
The embedder string should be updated again while landing. |
cjihrig
approved these changes
Jan 2, 2020
nodejs-github-bot
commented
Jan 3, 2020
Collaborator
nodejs-github-bot
commented
Jan 3, 2020
Collaborator
Member
|
BridgeAR pushed a commit
that referenced
this pull request
Jan 3, 2020
Original commit message: FreeBSD update of process library mapping listing. Not best to rely on /proc presence basically when the linux compatibily layer is enabled so going through more programmatically. Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65442} PR-URL: #31127 Refs: v8/v8@a4545db Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Jan 3, 2020
Original commit message: FreeBSD update of process library mapping listing. Not best to rely on /proc presence basically when the linux compatibily layer is enabled so going through more programmatically. Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65442} PR-URL: #31127 Refs: v8/v8@a4545db Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Jan 14, 2020
Original commit message: FreeBSD update of process library mapping listing. Not best to rely on /proc presence basically when the linux compatibily layer is enabled so going through more programmatically. Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65442} PR-URL: #31127 Refs: v8/v8@a4545db Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Feb 6, 2020
Original commit message: FreeBSD update of process library mapping listing. Not best to rely on /proc presence basically when the linux compatibily layer is enabled so going through more programmatically. Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65442} PR-URL: #31127 Refs: v8/v8@a4545db Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix library process mapping for FreeBSD.
Refs: v8/v8@a4545db
Original commit message :