Uh oh!
There was an error while loading. Please reload this page.
i18n: add caller to removal list for bidi in ICU55 - #3115
Closed
mhdawson wants to merge 1 commit into
Closed
Conversation
For ICU 55 we are currently stripping out bidi and the callers. AIX is more pedantic and identified an additional caller than needed to be stripped out. This PR adds that caller to those stripped out.
mhdawson
commented
Sep 29, 2015
MemberAuthor
@srl295 can you review this one. |
mhdawson
commented
Sep 29, 2015
MemberAuthor
@srl295 can you also comment on whether we should pull this back into 4.X |
srl295
commented
Sep 29, 2015
Member
@mhdawson I think it should be backported everywhere the "ICU 55 bump" was backported |
srl295
commented
Sep 29, 2015
via email
Member
reviewed also. LGTM. |
mhdawson
commented
Sep 30, 2015
MemberAuthor
mhdawson added a commit
that referenced
this pull request
Sep 30, 2015
For ICU 55 we are currently stripping out bidi and the callers. AIX is more pedantic and identified an additional caller than needed to be stripped out. This PR adds that caller to those stripped out. PR-URL: #3115 Reviewed-By: Steven Loomis <srloomis@us.ibm.com>
mhdawson
commented
Sep 30, 2015
MemberAuthor
Landed as 3f62c40 |
mhdawson
commented
Sep 30, 2015
MemberAuthor
Marked as land on v0.12, v3.x and v4.x as that is where "ICU 55 bump" was backported |
mhdawson added a commit
that referenced
this pull request
Oct 2, 2015
For ICU 55 we are currently stripping out bidi and the callers. AIX is more pedantic and identified an additional caller than needed to be stripped out. This PR adds that caller to those stripped out. PR-URL: #3115 Reviewed-By: Steven Loomis <srloomis@us.ibm.com>
Fishrock123
commented
Oct 19, 2015
Contributor
@mhdawson does this also apply to ICU 56? |
srl295
commented
Oct 19, 2015
via email
Member
Should apply to 56 too |
MylesBorins
commented
Nov 17, 2015
Contributor
landed in v4.x-staging in a0b35bf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ICU 55 we are currently stripping out bidi and
the callers. AIX is more pedantic and identified
an additional caller than needed to be stripped out.
This PR adds that caller to those stripped out.