Uh oh!
There was an error while loading. Please reload this page.
src: add build Github Action - #31153
Closed
gengjiawen wants to merge 1 commit into
Closed
Conversation
gengjiawenforce-pushed
the
feature/ci
branch
2 times, most recently
from
January 2, 2020 12:40
42af02d to
291cc89Comparemscdex
commented
Jan 2, 2020
Contributor
s/Aciton/Action/ in commit message |
gengjiawen
commented
Jan 8, 2020
MemberAuthor
cc @nodejs/build |
cclauss
reviewed
Jan 8, 2020
Uh oh!
There was an error while loading. Please reload this page.
cclauss
approved these changes
Jan 8, 2020
nodejs-github-bot
commented
Jan 9, 2020
Collaborator
nodejs-github-bot
commented
Jan 9, 2020
Collaborator
addaleax
approved these changes
Jan 9, 2020
nodejs-github-bot
commented
Jan 9, 2020
Collaborator
cjihrig
approved these changes
Jan 9, 2020
gengjiawen added a commit
that referenced
this pull request
Jan 10, 2020
PR-URL: #31153 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gengjiawen
commented
Jan 10, 2020
MemberAuthor
Landed in 60026c7 |
This was referenced Jan 10, 2020
MylesBorins pushed a commit
that referenced
this pull request
Jan 16, 2020
PR-URL: #31153 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Mar 14, 2020
PR-URL: #31153 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Apr 2, 2020
PR-URL: nodejs#31153 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#31017
Currently not able to reuse common steps. See https://github.community/t5/GitHub-Actions/reusing-sharing-inheriting-steps-between-jobs-declarations/m-p/37849#M3100.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes