Skip to content

lib: Enhance use of Set with primordials - #31154

Closed
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:SetPrimordials
Closed

lib: Enhance use of Set with primordials#31154
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:SetPrimordials

Conversation

@Sebastien-Ahkrin

@Sebastien-AhkrinSebastien-Ahkrin commented Jan 2, 2020

Copy link
Copy Markdown
Contributor

Hello :D (i'm back)
For this PR I have added Set in the primordials eslint

And i just have created a line in "/lib/.eslintrc.yaml".

rules:
no-restricted-globals:
- name: Setmessage: "Use `const { Set } = primordials;` instead of the global."

And just add Set.

const{// [...]
Set,}=primordials;

I hope this new PR will help you :x

@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 2, 2020
@Sebastien-Ahkrin

Sebastien-Ahkrin commented Jan 2, 2020

Copy link
Copy Markdown
ContributorAuthor

Refs: #30697

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2020
@nodejs-github-bot

nodejs-github-bot commented Jan 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28091/

@nodejs-github-bot

nodejs-github-bot commented Jan 3, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28134/

@Trott

Trott commented Jan 4, 2020

Copy link
Copy Markdown
Member

Whoever lands this might wish to update the commit message to lib: use primordial for Set or something like that perhaps.

@nodejs-github-bot

nodejs-github-bot commented Jan 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28205/

Trott
Trott reviewed Jan 4, 2020
View reviewed changes
Comment threadlib/.eslintrc.yaml
Trott pushed a commit that referenced this pull request Jan 4, 2020
@Sebastien-Ahkrin@Trott
lib: replace Set global by the primordials
256c9a4
PR-URL: #31154
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

Trott commented Jan 4, 2020

Copy link
Copy Markdown
Member

Landed in 256c9a4

@TrottTrott closed this Jan 4, 2020
targos pushed a commit that referenced this pull request Jan 6, 2020
@Sebastien-Ahkrin@targos
lib: replace Set global by the primordials
3f21ad6
PR-URL: #31154
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeARBridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin@targos
lib: replace Set global by the primordials
e5b7d64
PR-URL: #31154
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin@BethGriggs
lib: replace Set global by the primordials
131d961
PR-URL: #31154
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Sebastien-Ahkrin@nodejs-github-bot@Trott@jasnell@cjihrig@devnexen@BridgeAR@trivikr