doc: add an example for util.types.isExternal by HarshithaKP · Pull Request #31173 · nodejs/node

HarshithaKP · 2020-01-03T07:37:53Z

added usage example for util.types.isExternal
which was missing owing to the complexity.
Used a combination of n-api and js to demonstrate
usage of the api.

Fixes: #20604

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: nodejs#31173 (comment)

There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: #31173 (comment) PR-URL: #31214 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

added usage example for util.types.isExternal which was missing owing to the complexity. Used a combination of n-api and js to demonstrate usage of the api. Fixes: nodejs#20604

HarshithaKP · 2020-01-10T12:57:54Z

Ping @addaleax @Trott @jasnell, please take a look. I just rebased.

Trott

LGTM with @addaleax's nits

added usage example for util.types.isExternal which was missing owing to the complexity. Used a combination of n-api and js to demonstrate usage of the api. PR-URL: #31173Fixes: #20604 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR · 2020-01-13T11:52:13Z

Landed in f4a4a1a 🎉

There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: #31173 (comment) PR-URL: #31214 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

added usage example for util.types.isExternal which was missing owing to the complexity. Used a combination of n-api and js to demonstrate usage of the api. PR-URL: #31173Fixes: #20604 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: #31173 (comment) PR-URL: #31214 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

added usage example for util.types.isExternal which was missing owing to the complexity. Used a combination of n-api and js to demonstrate usage of the api. PR-URL: #31173Fixes: #20604 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Jan 3, 2020

jasnell reviewed Jan 3, 2020
View reviewed changes