Skip to content

lib: replace BigInt64Array global by the primordials - #31193

Closed
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:BigInt64ArrayPrimordials
Closed

lib: replace BigInt64Array global by the primordials#31193
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:BigInt64ArrayPrimordials

Conversation

@Sebastien-Ahkrin

@Sebastien-AhkrinSebastien-Ahkrin commented Jan 5, 2020

Copy link
Copy Markdown
Contributor

Hello,
For this PR I have added BigInt64Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
no-restricted-globals:
- name: BigInt64Arraymessage: "Use `const { BigInt64Array } = primordials;` instead of the global."

And just add Set.

const{// [...]
BigInt64Array,}=primordials;

I hope this new PR will help you :x

@nodejs-github-botnodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jan 5, 2020
@Sebastien-Ahkrin

Sebastien-Ahkrin commented Jan 5, 2020

Copy link
Copy Markdown
ContributorAuthor

Refs: #30697

targos
targos approved these changes Jan 5, 2020
View reviewed changes
Comment threadlib/.eslintrc.yaml Outdated
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott

Trott commented Jan 8, 2020

Copy link
Copy Markdown
Member

Needs a rebase to fix the conflict. (Looks like you can just accept both the "theirs" and the "ours" changes and it will be fine.)

@Sebastien-Ahkrin

Sebastien-Ahkrin commented Jan 9, 2020

Copy link
Copy Markdown
ContributorAuthor

Needs a rebase to fix the conflict. (Looks like you can just accept both the "theirs" and the "ours" changes and it will be fine.)

Fix in progress 😄

@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28336/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 11, 2020
BridgeAR pushed a commit that referenced this pull request Jan 13, 2020
@Sebastien-Ahkrin@BridgeAR
lib: replace BigInt64Array global by the primordials
a2c4244
PR-URL: #31193
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR

BridgeAR commented Jan 13, 2020

Copy link
Copy Markdown
Member

Landed in a2c4244 🎉

MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@Sebastien-Ahkrin@MylesBorins
lib: replace BigInt64Array global by the primordials
108046d
PR-URL: #31193
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@Sebastien-Ahkrin@codebytere
lib: replace BigInt64Array global by the primordials
d1814b5
PR-URL: #31193
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Sebastien-Ahkrin@codebytere
lib: replace BigInt64Array global by the primordials
d00a1b9
PR-URL: #31193
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Sebastien-Ahkrin@nodejs-github-bot@Trott@BridgeAR@jasnell@addaleax@targos@cjihrig@trivikr